Code Monkey home page Code Monkey logo

Comments (3)

braw-lee avatar braw-lee commented on May 27, 2024

I want to fix #2767 which will build upon this commit, should I wait for this PR to be merged and create a new PR for that issue
or do you want me to handle that issue in this PR?
@P-E-P

from gccrs.

P-E-P avatar P-E-P commented on May 27, 2024

I want to fix #2767 which will build upon this commit, should I wait for this PR to be merged and create a new PR for that issue
or do you want me to handle that issue in this PR?
@P-E-P

We try to keep PRs short to make them easy to review. Usually when some changes depend on a given open PR people write something such as depends on #XXXX and keep the second PR in draft until the first one is accepted. They rebase the second PR on master once the first one is merged. We won't reject a PR because it solves two issues though.

from gccrs.

braw-lee avatar braw-lee commented on May 27, 2024

ok thanks,
since the commits were related and really small I add commits to same PR

from gccrs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.