Code Monkey home page Code Monkey logo

Comments (9)

praditkan avatar praditkan commented on May 29, 2024 1

I edited and added the screenshot.

I only added this line of code into your RSSelectionMenuController, and it fixed my problem.

self.backgroundView.frame = self.view.bounds

from rsselectionmenu.

rushisangani avatar rushisangani commented on May 29, 2024

@praditkan Could you please add a screenshot, what's the issue?
And probably the code how you're presenting the menu?

from rsselectionmenu.

rushisangani avatar rushisangani commented on May 29, 2024

@praditkan ideally any popup (formSheet) background should cover entire window width (master + detail), not only detail view.
You can take reference from iPad Settings app or alert presented on the iPad.

If we allow the user to select the item from the master view, while any popup is on the screen, then it's a bad UX because the user is expected to take any action in the popup or dismiss it.

from rsselectionmenu.

praditkan avatar praditkan commented on May 29, 2024

That is true in a sense of design best practice and preference.

However, your code still allow us to use this way.
Then this is still a defect, isn't it?
It displays off the screen.

I just hope this would make it more robust to use.
I could be wrong sorry.
I'm a new swift developer anyway.

from rsselectionmenu.

rushisangani avatar rushisangani commented on May 29, 2024

Maybe you can present from splitViewController and then check?
menu.show(type: <type here>, from: self.splitViewController)

from rsselectionmenu.

rushisangani avatar rushisangani commented on May 29, 2024

@praditkan Were you able to resolve this?

from rsselectionmenu.

praditkan avatar praditkan commented on May 29, 2024

Ah this one work!!!

menu.show(type: <type here>, from: self.splitViewController)

Thank you so much.

from rsselectionmenu.

praditkan avatar praditkan commented on May 29, 2024

I found another issue.

The same project I did change self.splitViewController as you advised for those detail view.

It happens again this time within the view that is presented modally.

I tried this but it doesn't work.

menu.show(type: <type here>, from: self.presentingViewController!)

from rsselectionmenu.

rushisangani avatar rushisangani commented on May 29, 2024

@praditkan why did you use from: self.presentingViewController! here?
I believe it's not the issue in the library. Maybe you can try presenting from another view controller or application window.

Closing this issue for now:)

from rsselectionmenu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.