Code Monkey home page Code Monkey logo

Comments (3)

rurban avatar rurban commented on June 2, 2024

Please check the polymur branch

from smhasher.

orlp avatar orlp commented on June 2, 2024

That was quick! Looks good, just one nitpick on the code. Instead of 0xfedbca9876543210 | seed I'd suggest 0xfedbca9876543210 ^ seed in polymur_seed_init just to make sure no bits of the seed get lost.

Also note that, depending on the seed, there is a ~7% chance PolymurHash can fail the Sparse 16-bit key test. But I believe this to be a flaw in the test as even a perfect random oracle does this, see #114 (comment) . So perhaps you may want to re-open that issue.

And perhaps PolymurHash could get added to your list of "fastest hash functions on x86_64 without quality problems", because I do think its speed qualifies it as it's faster than some of those on the list, and Polymur gives much better guarantees than all of those on the list.

from smhasher.

rurban avatar rurban commented on June 2, 2024

added

from smhasher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.