Comments (3)
ruipin
commented on June 2, 2024
Hmm, I'm actually no longer certain why I used a positive look-behind here. It could easily be replaced by a \/.
Guess there's no harm in changing it, even if Safari isn't officially supported. I'll push it together with the changes for #19 that I'm working on.
from fvtt-lib-wrapper.
ruipin
commented on June 2, 2024
v1.5.4.0 resolves #19 and removes the usage of positive lookbehinds in the module detection code for both the shim and the full library.
Note that I do not have access to Safari, so you'll have to test it yourself. I'll keep this open until I get confirmation the issue is fixed.
Of course, modules that rely on the shim will still fail, unless they update. The shim should, in most cases, be a drop-in replacement, so you can always patch them yourself though.
from fvtt-lib-wrapper.
caewok
commented on June 2, 2024
I can confirm that lib-wrapper now loads in Safari Tech Preview without this error. Thanks!
from fvtt-lib-wrapper.
Related Issues (20)
- Question: Help with a possible async issue HOT 2
- The Settings Application is unable to handle manual wrappers when package ID auto-detection fails. HOT 1
- crash on preexisting world HOT 1
- Allow user to bind arguments when calling libWrapper.register HOT 2
- [BUG] Incompatibility between Settings Extender and libWrapper in V9 HOT 4
- [BUG?] libWrapper: A non-critical error occurred while initializing libWrapper. HOT 4
- [Request] Reduce logging verbosity HOT 5
- [BUG] Malformed log verbosity setting prevents libWrapper initialisation HOT 2
- SW5e: Libwrapper seems to be returning NaN for ability check mod, saving throw mod, AC, Initiative mod, and potentially others. HOT 7
- [CORE ISSUE] libWrapper fails on v10p1 / v10p2 when modules try to register a wrapper HOT 3
- V10 compatibility for module.json HOT 3
- Question re wrapping order HOT 2
- [BUG] HOT 2
- Error-Warnings due to v9 style data access HOT 1
- [BUG] Incorrect error message when calling the libWrapper API before the libWrapper.Ready hook HOT 1
- [BUG] URL to faulty module's page is run-in with following sentence, merging the two HOT 8
- [BUG] HOT 1
- weaponProf variable unassaigned? HOT 1
- [BUG] Info from `Hooks.onError` getting lost HOT 3
- Reword compatibility warnings and improve README to be more user-friendly HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fvtt-lib-wrapper.