Comments (2)
shemetz
commented on June 2, 2024
I believe the fix is to add a type argument to the shim register function, and if that type is override, to call fn without the original argument.
from fvtt-lib-wrapper.
ruipin
commented on June 2, 2024
You are completely right, this was an oversight from my end.
Originally, the OVERRIDE type would also receive the next_fn argument. This was changed later on, but by then I had already written the shim, and forgot to change the test-case for it.
3259c85 fixes this, by properly checking the type parameter for OVERRIDE. It also tweaks the test cases to ensure that this situation (OVERRIDE with parameters) is correctly tested.
Thanks for the report, and sorry for any inconvenience!
from fvtt-lib-wrapper.
Related Issues (20)
- Question: Help with a possible async issue HOT 2
- The Settings Application is unable to handle manual wrappers when package ID auto-detection fails. HOT 1
- crash on preexisting world HOT 1
- Allow user to bind arguments when calling libWrapper.register HOT 2
- [BUG] Incompatibility between Settings Extender and libWrapper in V9 HOT 4
- [BUG?] libWrapper: A non-critical error occurred while initializing libWrapper. HOT 4
- [Request] Reduce logging verbosity HOT 5
- [BUG] Malformed log verbosity setting prevents libWrapper initialisation HOT 2
- SW5e: Libwrapper seems to be returning NaN for ability check mod, saving throw mod, AC, Initiative mod, and potentially others. HOT 7
- [CORE ISSUE] libWrapper fails on v10p1 / v10p2 when modules try to register a wrapper HOT 3
- V10 compatibility for module.json HOT 3
- Question re wrapping order HOT 2
- [BUG] HOT 2
- Error-Warnings due to v9 style data access HOT 1
- [BUG] Incorrect error message when calling the libWrapper API before the libWrapper.Ready hook HOT 1
- [BUG] URL to faulty module's page is run-in with following sentence, merging the two HOT 8
- [BUG] HOT 1
- weaponProf variable unassaigned? HOT 1
- [BUG] Info from `Hooks.onError` getting lost HOT 3
- Reword compatibility warnings and improve README to be more user-friendly HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fvtt-lib-wrapper.