Comments (6)
Hmm this is actually going to be more complicated than I realized. Because this was probably set up using the cocoapods gem, I think that carthage won't work because Notepad
isn't a project, it's a scheme within Example.xcodeproj
and even those it's marked as shared Carthage can't find it which is why I suspect it fails carthage build
and carthage update
commands.
I'll have to put up a larger PR or a series of PRs but there's a couple of things I want to change here:
- Make the example project a standalone project and/or a Playground
- convert Nodepad to it's own xcodeproj so carthage can find it
- add fastlane for automation
- add swiftlint for linting
- manage gem dependencies via bundler
- switch to git-flow
- write unit tests
So really it's a lot of things but I'll probably do things in that order when I get a free afternoon.
from notepad.
Someday young padawon, someday you will be.
from notepad.
I see two options:
- Doesn't Carthage work with Workspaces, too? Then you could add a root workspace to expose the shared scheme.
- Create a
Notepad.xcodeproj
in the project root with 2 library targets (iOS and macOS). Share their schemes for Carthage, too. Then addExample-macOS
andExample-iOS
app targets to the project as well (which will be ignored by Carthage).
I'm no CocoaPods wiz, so I don't know if that will cause more trouble than good.
from notepad.
Yeah that's a better idea actually, great suggestions 👍
This repo desperately needs tests as well. No open-source library should be distributed without tests.
from notepad.
@startupthekid 😢you know I'm not good at tests!
from notepad.
@startupthekid do you think you'll get a chance to work on this? No worries if not!
from notepad.
Related Issues (20)
- Suggestion box is too big HOT 4
- Align text in the centre HOT 2
- Swift 4 support (on CocoaPods)? HOT 3
- 3 spaces make it not working HOT 3
- Internal Protection Level HOT 9
- Line break inside bold or italic markup leaves first part marked up HOT 1
- attribute run ranges are in inconsistent state HOT 2
- Please add the possibility to change the syntax color and clickable links. HOT 4
- macOS pod installation HOT 3
- Issue with Xcode 10.2 HOT 2
- Style boldItalics not rendered correctly HOT 9
- Unable to load your theme file. HOT 11
- Storyboard support HOT 8
- Objective C support HOT 1
- Use System Font HOT 2
- Custom attributes HOT 1
- Placeholder support
- Hide markdown syntax as cursor leaves the position? HOT 4
- New release version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from notepad.