Code Monkey home page Code Monkey logo

Comments (6)

thebarndog avatar thebarndog commented on May 25, 2024 1

Hmm this is actually going to be more complicated than I realized. Because this was probably set up using the cocoapods gem, I think that carthage won't work because Notepad isn't a project, it's a scheme within Example.xcodeproj and even those it's marked as shared Carthage can't find it which is why I suspect it fails carthage build and carthage update commands.

I'll have to put up a larger PR or a series of PRs but there's a couple of things I want to change here:

  1. Make the example project a standalone project and/or a Playground
  2. convert Nodepad to it's own xcodeproj so carthage can find it
  3. add fastlane for automation
  4. add swiftlint for linting
  5. manage gem dependencies via bundler
  6. switch to git-flow
  7. write unit tests

So really it's a lot of things but I'll probably do things in that order when I get a free afternoon.

from notepad.

thebarndog avatar thebarndog commented on May 25, 2024 1

Someday young padawon, someday you will be.

from notepad.

DivineDominion avatar DivineDominion commented on May 25, 2024

I see two options:

  1. Doesn't Carthage work with Workspaces, too? Then you could add a root workspace to expose the shared scheme.
  2. Create a Notepad.xcodeproj in the project root with 2 library targets (iOS and macOS). Share their schemes for Carthage, too. Then add Example-macOS and Example-iOS app targets to the project as well (which will be ignored by Carthage).

I'm no CocoaPods wiz, so I don't know if that will cause more trouble than good.

from notepad.

thebarndog avatar thebarndog commented on May 25, 2024

Yeah that's a better idea actually, great suggestions 👍

This repo desperately needs tests as well. No open-source library should be distributed without tests.

from notepad.

ruddfawcett avatar ruddfawcett commented on May 25, 2024

@startupthekid 😢you know I'm not good at tests!

from notepad.

ruddfawcett avatar ruddfawcett commented on May 25, 2024

@startupthekid do you think you'll get a chance to work on this? No worries if not!

from notepad.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.