`Isolate::low_memory_notification` fails to lock Isolate about mini_racer HOT 5 CLOSED

Yeah, I rebased so the commit sha changed to the one you mentioned but that's the one.

from mini_racer.

Using it would therefore make low_memory_notification useless while the isolate is not in use, which appears to be an intended use-case for the method.

Correct. The original idea behind this is to repeatedly run short-lived scripts and get results, but they might accumulate garbage. In between, when memory usage gets too high, trigger libv8 GC via low mem notification.

In that specific use case this fits the bill:

In particular, doing so would cause any rb-thread calling low_memory_notification to block until other threads using the isolate have unlocked it (for JavaScript execution, this means the script has finished running).

So it seems like in that case, which is the only one where mini_racer makes use of low_memory_notification, the following would be fine:

Normally I would simply slap a Locker guard { isolate_info->isolate } prior to the call

I guess the following bit of code (notably the @eval_thread check) was supposed to sort of ensure that on the Ruby side but it's not sufficient anymore and doesn't cater for whatever libv8 is doing internally:

The two debug+release cases you described plus the lack of any other feature that would fit the bill seem to make it clear that v8 intents us to just use the lock guard, so let's do that.

from mini_racer.

I've done just that in ac520dd (#284), thanks a lot!

from mini_racer.

Not 100% sure if the original issue got 100% fixed, but it looks like it (in c195239), right, @lloeki?

from mini_racer.

Fixed/Addressed in c195239, released as v0.12.0

from mini_racer.