NoMethodError (undefined method `compact' for "(cyclic structure)":String in Browser#css about ferrum HOT 7 CLOSED

@ttilberg as far as I can tell I AM using the master branch.

I did some digging and I found the method implementation here

      def css(selector, within: nil)
        code = <<~JS
          let selector = arguments[0];
          let within = arguments[1] || document;
          let results = within.querySelectorAll(selector);
          arguments[2](results);
        JS


        evaluate_async(code, @page.timeout, selector, within)
      end

I copied the JS code definition and ran the same browser.evaluate_async call in my local console. Still getting the same error.

HOWEVER, while futzing around with this I also found the solution: document.querySelector() returns a NodeList, not an Array (as the XPath version does). So, I changed the JS code to turn the NodeList into an Array, like so:

let selector = arguments[0];
let within = arguments[1] || document;
let results = [].slice.apply(within.querySelectorAll(selector));
arguments[2](results);

Running this code using browser.evaluate_async worked, and returned the expected result.

from ferrum.

Sorry guys I had a branch when you tagged me but then life came in and walked me away lol. I like your soultion @PandaWhisperer and I'm gonna intro one more thing, let me rebase and continue working in my branch.

from ferrum.

Related: #73 #13

@PandaWhisperer can you try with master branch? It was mentioned in #73 that a fix was added, but it looks like a new release hasn't been cut.

Edit: not a fix, just perhaps a better error.

from ferrum.

See this note: #73 (comment)

from ferrum.

@ttilberg does this make sense?

I've been trying to come up with a test case for this scenario, but so far I have failed. I see the Browser#css method has tests and works for the cases you have for it. So far I haven't been able to figure out what's different between your test cases and "in the wild" pages.

from ferrum.

I think you mean to tag @route -- I'm just a random onlooker who keeps close tabs on the project ;)

from ferrum.

I merged one more thing regarding cyclic structure but @PandaWhisperer I think this rubycdp/cuprite@62e2a27 should have fixed your issue any chance you were using old branches? Please upgrade ferrum and let me know if it's still an issue for you. Thanks!
PS: Tried your scenario on master, everything works now.

Sorry I forgot we have different selectors in ferrum. Fixing right now

from ferrum.