Converters doesn't work on generate_line about csv HOT 6 CLOSED

:converters option is for reading CSV data not for writing CSV data.
Can you show your use case for using converters on wiring CSV data?

from csv.

Basically because of a this CVE

We are using ActiveAdmin and it uses generate_line to generate CSVs. We basically want to add an apostrophe in the beggining of the line if it starts with an = sign. (Basically samething as mentioned here). We didn't monkey-patch it because in Ruby's CSV docs we saw:

generate_line(row, options = Hash.new)
...
The options parameter can be anything ::new understands.
...

Perhaps the doc should be changed?

Cheers

from csv.

As @kou comments, the converters are for reading, not writing, and yes, perhaps the doc need to be more specific. More than 'anything than ::new understand' should be something like 'anything that ::new understands and applies'.

Checking the code, and correct me if I'm wrong, the only supported options when using generate_line are

In this case are more than only :colsep, :rowsep and :quote:

v = ["'a'", 'b']
headers = %w(first second)
l1 = CSV.generate_line(v, row_sep: '.', col_sep: '~', quote_char: '!',
                       force_quotes: true, write_headers: true, headers: headers, 
                       encoding: 'EUC-JP')
 => "!first!~!second!.!'a'!~!b!."
l1.encoding
 => #<Encoding:EUC-JP>

from csv.

@paniko0 Thanks for describing your use case. It makes sense.

We can't reuse :converters for this use case because it's for CSV -> Ruby. We need Ruby -> CSV for this use case.

It's OK to me that we add :write_converters for this use case.

from csv.

@esparta Thanks for your follow-up comment.
We can't reuse existing options for this use case because we need to care each data for this use case.

from csv.

Hi @kou,

Sorry about the late response. I can add the write_conventers option. Can you elaborate a little bit more what this method should do? I am assuming it should receive a Proc and run it against each value of the array. Am I in the right direction?

Cheers

from csv.