Code Monkey home page Code Monkey logo

Comments (7)

contentfree avatar contentfree commented on August 23, 2024

To answer my last question, a quick workaround is to nilify all empty strings in the array given to generate_line ala values.map{|v| v.blank? ? nil : v} (using the blank? core extension, of course)

from csv.

kou avatar kou commented on August 23, 2024

Why is ""|"" your problem? Can you show a problem case?

from csv.

contentfree avatar contentfree commented on August 23, 2024

It's just unusual to see quoted values in PSV. Especially when unnecessary (as in the case with an empty string).

In the following examples, both the nil value and string-with-a-space generate expected PSV – no quotes in either. But the example that includes an empty string generates PSV with unnecessary quotes:

> puts CSV.generate_line(["There is a nil",nil,"column in this"], col_sep: '|')
There is a nil||column in this

> puts CSV.generate_line(["There is a space-only"," ","column in this"], col_sep: '|')
There is a space-only| |column in this

> puts CSV.generate_line(["There is an empty","","column in this"], col_sep: '|')
There is an empty|""|column in this

Why does the final example put quotes in the text? I assert that many systems use PSV for data exchange would be surprised to find quotes in the PSV unless the quotes should be part of the value. So, in the final (and what I consider surprising) example, many people would treat the quoted value as the literal value "".

from csv.

contentfree avatar contentfree commented on August 23, 2024

If a quote_empty_strings: true option were introduced (defaulting to true for backwards compatibility), I'd be satisfied.

from csv.

stevendaniels avatar stevendaniels commented on August 23, 2024

This is the expected behavior. Not returning "" would cause the field to be parsed as nil.

# with quotes
 CSV.parse('There is an empty|""|column in this', col_sep: '|')
# => [["There is an empty", "", "column in this"]]

# without quotes
CSV.parse('There is an empty||column in this', col_sep: '|')
#=> [["There is an empty", nil, "column in this"]]

from csv.

kou avatar kou commented on August 23, 2024

Ah, do you want to use the csv library to parse the PSV spec https://github.com/jgis/psv-spec data?
I didn't know PSV.

If you want to use the csv library to parse the PSV spec data, we need to add backslash escape feature instead of add nil and empty string data customize feature: https://github.com/jgis/psv-spec#6-some-characters-are-escaped-by-a-leading-backslash

from csv.

kou avatar kou commented on August 23, 2024

I've added quote_empty option.

from csv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.