Rubocop integration? about csv HOT 6 CLOSED

While I understand the feelings about the code styles in the repo, Rubocop is very opinionated, which makes it extremely difficult to get everyone on the same page. I took a quick look at the source code and found it very readable and easy to understand even without Robocop. Personally, I don't see why we should incorporate Rubocop into this project.

That being said, the two points you brought up are totally legitimate. I'm not sure about the odd? one (odd? is definitely more readable, but x % 2 != 0 is not that bad), but I'd happily merge a PR that removes the duplicate private in if you could send one.

from csv.

@ShockwaveNN As I described in the recent commit b8766d8, we don't use RuboCop in this small repository.

Please file your pull-request in your own coding style with some adjustments to fit the lines around of your change.

from csv.

I don't like RuboCop but it's OK to me if we start from a loose configuration that doesn't report anything for the current code base.

from csv.

@kou I think currently RuboCop generate pretty interesting enhancements for current codebase, at least for better readability.
F.e. replacing

Or duplicate private on

And since gem has spec.required_ruby_version = ">= 2.4.0" we can remove redundant encoding: UTF-8 in some test files.

And so on

from csv.

Do you mean that "we should start from an optimized configuration"?
It your answer is yes, I object this proposal.

from csv.

Ok I thing I got official statement about RuboCop from dev team and seems this issue could be closed.
I don't think I can adapt RuboCop config file to code style of current repository , or if I could I don't think workflow would be effective.

@yuki24 I create PR about duplicate private #28

from csv.