2.5 --> 2.6: backwards incompatible change in MalformedCSVError#new about csv HOT 7 CLOSED

Thanks.
It seems that it's an application specific error and it's not a general CSV error. So you should use your own error class instead of reusing CSV::MalformedCSVError.

from csv.

@kou well, in our specific case, we have a logic with check of valid headers

...
raise_malformed_csv_error unless valid_headers?
...

    def raise_malformed_csv_error
      raise CSV::MalformedCSVError
    end

    def valid_headers?
      has_required_columns? && has_only_supported_columns?
    end

So, I'm thinking about this error like a any error of CSV parsing, like a it's an explicit error, which was inherited from RuntimeError.

from csv.

Could you show codes that creating CSV::MalformedCSVError?

from csv.

@kou just this:

    def raise_malformed_csv_error
      raise CSV::MalformedCSVError
    end

with 2.6 ruby it's raised this:

     Failure/Error: raise CSV::MalformedCSVError
     
     ArgumentError:
       wrong number of arguments (given 0, expected 2)

because of this:
36e1cb2

For Ruby 2.5 code was without required arguments:

  # The error thrown when the parser encounters illegal CSV formatting.
  class MalformedCSVError < RuntimeError; end

  #

https://bugs.ruby-lang.org/issues/16133

from csv.

Thanks.
One more question. Why do you want to raise CSV::MalformedCSVError manually?

from csv.

@kou okay, thanks, I will take note and we will discuss it with colleagues. We've just got this error while ruby update. Now we'got how to resolve it. Thank you

from csv.

OK. I close this.

from csv.