Issue: quite slow getting the image in the sample about previewseekbar HOT 24 CLOSED

The sample just contains an example of how to use it with ExoPlayer. It's not the perfect solution, that's why I created the section "Improvements" in the Readme: https://github.com/rubensousa/PreviewSeekBar#improvements

The point of open sourcing this library was releasing the morphing view and getting ideas for better solutions on how to download the video thumbnails.

Local opens an Activity to test the PreviewSeekBar with a simple view.

from previewseekbar.

But in the screenshots it's much faster. Why didn't you use it here too?

from previewseekbar.

I did, the sample is the same. Just different network conditions.

from previewseekbar.

I'll close this since I've answered your question. If you come up with a better solution for loading the thumbnails, let me know.

from previewseekbar.

Network conditions? I have a good internet connection.
How about putting a short video inside the sample itself, instead?

from previewseekbar.

I'll try to find a shorter one, but this doesn't solve the slow loading problem.

from previewseekbar.

How come it works fine for you on the gif-screenshot on the repo main page? It seems smooth there...

from previewseekbar.

Like I said, my guess is different network conditions (latency or server with high load, I don't know). It works faster in my emulator.

from previewseekbar.

Can you please add a way inside the project, to show a built in video, so that it will be possible to know if that's really the cause to this issue ? The video file could even be on the device instead of inside the app.

from previewseekbar.

Yes, I can do that. I'll replace the current local action to load a video from the storage.
I'll close this once I replace the current stream with a better one.

from previewseekbar.

Close what?
I don't understand.

from previewseekbar.

This issue. Since local playback doesn't have to do with it.

from previewseekbar.

Why close it? We don't know for sure what's the reason for it being slow. I asked if you can use a local file, to check if the issue is because of slow connection or not.

from previewseekbar.

Nevermind, I just re-read the issue title and it makes sense to keep it open. Sorry for the misunderstanding.

from previewseekbar.

There are two gifs in the README, the fast one is google play movies, the slower one is this library. Just make sure you're comparing against the right one :)

from previewseekbar.

@kford55 Oh, so you say it's because of using a server that has a good connection, not just the client (and I have a good connection and a good phone).

from previewseekbar.

@AndroidDeveloperLB nope just making sure that you are comparing the correct screenshots. This isn't the same implementation as Google Play movies, so we can't compare speed with this library to speed of Google Play Movies.

from previewseekbar.

oh ok.

from previewseekbar.

@AndroidDeveloperLB, did you think the first screenshot was from this sample?

from previewseekbar.

@rubensousa I thought that it shows how well the library can perform. I'm still not sure about this, because it doesn't handle a local video file yet. Only from the Internet, which could cause it to be slow, because it needs to fetch the thumbnail from a video.

from previewseekbar.

I'll try to add local video support this week.

from previewseekbar.

Finally had time to this. @AndroidDeveloperLB, can you check the sample again?
It was done in commit: e3f6db2

from previewseekbar.

seems to work, but for some reason it couldn't open many mp4 files (all WhatsApp videos went gray). The one I created from the camera was ok.
BTW, the "toggle" doesn't seem to work well. Usually it appears and disappears right away.

from previewseekbar.

I only tested videos from the camera and screen recordings. I'll take a look at the toggle issue

from previewseekbar.