Comments (4)
I already ran the tests myself, and had one test failing before and after installing your changes to elm-solve-deps-wasm due to the changed JSON.parse error messages. So that should be good to go.
Cool, thanks!
To make the test pass again across Node.js versions, Iād just do the simplest thing that solves the problem in the test. Not sure what without looking closer to it.
I'll send in a PR to patch the comparison sometime.
from node-test-runner.
P.S.: If you're comfortable, @lydell, I think elm-review's test suite is enough to merge mpizenberg/elm-solve-deps-wasm#3 given that these don't seem to work, but if you'd prefer to test those changes first, I can work on this. I might either way š¤·āāļø
from node-test-runner.
I already ran the tests myself, and had one test failing before and after installing your changes to elm-solve-deps-wasm due to the changed JSON.parse error messages. So that should be good to go.
To make the test pass again across Node.js versions, Iād just do the simplest thing that solves the problem in the test. Not sure what without looking closer to it.
from node-test-runner.
Opened #634
from node-test-runner.
Related Issues (20)
- Detect when we run tests twice
- Crash when --output is set for `elm-test make` HOT 8
- Unable to install npm package for 0.18.13-beta4 HOT 12
- Erroneously requires indirect dependencies specified for packages during watch HOT 3
- node 10 is eol
- No output for successful test runs HOT 4
- 0.19.1-revision8 Changelog HOT 1
- Running elm-test leaves fish shell in a weird state HOT 3
- Implicitly exposed tests not found if test module contains a character literal with a unicode sequence HOT 1
- Allow running just non-fuzzed tests HOT 1
- Check if the file read/write in the dependency cache can cause issues in the solver HOT 2
- elm-test doesn't work with Yarn 2 HOT 3
- Junit reporter breaks with new error messages of elm-program-test HOT 2
- RuntimeError: unreachable HOT 14
- Print statistics/progress on signal SIGUSR1 (Linux) / SIGINFO (macOS) HOT 1
- Support --watch for "elm-test make"
- Better support for long running tests
- from 0.19.1-revision2 to 0.19.1-revision7 (btu same with 9 and 12) skip some tests running HOT 7
- Deduplicate src-dirs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-test-runner.