Need new line inserted when <details> tag opened. about details-polyfill HOT 7 CLOSED

One small improvement I noticed after opening this issue is that if you add a style to details with display: block, it improves the first level of nesting. So something like this in the injectStyle - line 2 is the new line :-

injectStyle('details-polyfill-style',
  'html.no-details ' + DETAILS + ' { display: block; }\n' +
  'html.no-details ' + DETAILS + ':not([open]) > :not(' + SUMMARY + ') { display: none; }\n' +
  'html.no-details ' + DETAILS + ' > ' + SUMMARY + ':before { content: "\u25b6"; display: inline-block; font-size: .8em; width: 1.5em; }\n' +
  'html.no-details ' + DETAILS + '[open] > ' + SUMMARY + ':before { content: "\u25bc"; }' )

from details-polyfill.

Thanks for the report! I'm not sure how to address this either but a PR would be appreciated.

There are other details polyfills out there to also try in case this one doesn't fit your use case.

from details-polyfill.

I will look into making a Pull Request (PR). I am a new Git Hub user so bear with me!

from details-polyfill.

Ok, I think I have done what you meant. To create a Pull Request, I first had to make the change to index.js in a clone and then do a Pull Request on that. I cannot for the life of me work out how to link the Pull Request to this Issue though. Help docs suggests I can do so, but the button it suggests I click just doesn't exist. Perhaps it is something that must be done by someone with write access to this repository, which I do not have. Do let me know if I have not done it right. First time in :-)

from details-polyfill.

Hi @rstacruz - I see this is still open. Is that because I haven't put it into the correct state? As I said, I am a new user on GitHub, so I may have missed some step in the process that comes naturally to you. In case it is not clear, I have made the change required and am ready for this to be merged in. Can you let me know if this branch is not in the correct state to merge in. Thanks.

from details-polyfill.

I just merged it - sorry been a bit busy lately. I've published your changes as 1.2.0. :)

from details-polyfill.

Thank you. I was concerned that I hadn't done something. Thank you so much for your help. Great to learn how all this process stuff works. Cheers!

from details-polyfill.