Code Monkey home page Code Monkey logo

Comments (6)

gwroldan avatar gwroldan commented on August 11, 2024

The tests I'm doing with the files of this repo.

from ngx-input-file.

rsaenen avatar rsaenen commented on August 11, 2024

I will flag this package to deprecated and make a new component more modern and friendly user. Don't hesitate to contribute to this package too.

from ngx-input-file.

rsaenen avatar rsaenen commented on August 11, 2024

To add another point, the disconnection of the model comes from with using wrong function.
When manipulating the model to add or remove files, the reference of the array (model) will be loose.
It causes by thing function I guess:

/**
     * Remove handler.
     */
    private removeHandler(): void {
        this.dropZoneDisabled = false;
        this.inputFile.nativeElement.value = '';
        this.model = new Array<File>();
    }

from ngx-input-file.

padjon avatar padjon commented on August 11, 2024

came across this bug recently too.
clearing the array instead of replacing it fixes the disconnection:

private removeHandler(): void {
        this.dropZoneDisabled = false;
        this.inputFile.nativeElement.value = '';
        this.model.splice(0, this.model.length);
}

from ngx-input-file.

padjon avatar padjon commented on August 11, 2024

Created a pull-request for the issue: #10

from ngx-input-file.

rsaenen avatar rsaenen commented on August 11, 2024

Thanks for contributing.
The splice is the solution to keep the reference and double binding.

Released with 1.0.4

from ngx-input-file.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.