SDURLCache.m line 189 issue about sdurlcache HOT 2 OPEN

This complies to the HTTP spec. To prevent from clock skewing, HTTP client must not use their own clock to compute expiration but server's by using the Date response header. If a server doesn't provide a Date response header, response should be considered as uncacheable.

By the way, SDURLCache is no longer necessary as iOS 5+ implemented disk cacking.

from sdurlcache.

Agreed, but you still need some code if you want to do cache introspection. "HTTP client must not use their own clock to compute expiration but server's by using the Date response header" I agree, but isn't the code in question doing what you said it should not?

// Date is read from cached response as yesterday at 8am

  NSTimeInterval expirationInterval = 0;
    NSDate *expirationDate = [NSURLCache dateFromHttpDateString:expires];

// expires is today at 8am
if (expirationDate)
{
expirationInterval = [expirationDate timeIntervalSinceDate:date];
}

// time interval is 24 hours
if (expirationInterval > 0)
{
// Convert remote expiration date to local expiration date
return [NSDate dateWithTimeIntervalSinceNow:expirationInterval];

// Return now + 24 hours, calculated using client's clock
}
else

from sdurlcache.