Code Monkey home page Code Monkey logo

Comments (5)

Yuyz0112 avatar Yuyz0112 commented on August 22, 2024

In the latest release, there is an option to configure the block class name https://github.com/rrweb-io/rrweb/blob/master/src/types.ts#L239

Some previous discussion:
#1
#23

Is the block hook still needed with this implementation? Since the block check may be triggered very frequently, personally I prefer some simple check instead of calling a function.

from rrweb.

alienzhou avatar alienzhou commented on August 22, 2024

Thanks! After reading these, I agree that performance counts. And maybe this configuration helps.

However, I meet a problem. I want to block two elements (class .slide-banner, class .feed-back) in the page when recording. It seems that I can just block one by blockClass.
Or I have to make the maintainers update their code.

from rrweb.

Yuyz0112 avatar Yuyz0112 commented on August 22, 2024

Maybe extend the type of blockClass from string to string | RegExp?

from rrweb.

alienzhou avatar alienzhou commented on August 22, 2024

Good idea. It helps.

from rrweb.

Yuyz0112 avatar Yuyz0112 commented on August 22, 2024

@alienzhou in the 0.7.12 release the block class option now accept RegExp for checking. But there is still one thing left.
We currently apply some styles for the blocked area when replaying, based on injecting some dynamic stylesheets into the <iframe/>.
And I think there is no way to do things like this on RegExp type class name matcher.

from rrweb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.