Comments (7)
Yuyz0112
commented on August 22, 2024
#1 Described why we use this strategy in the issue, and feedback and discussion are welcomed.
from rrweb.
sammdec
commented on August 22, 2024
Apologies I didn’t see these. While I agree the class-names are good my suggestion would be to be able to configure the class name. As some people implementing rrweb in apps implementation details may be hidden so the rr-prefix might not make sense
from rrweb.
Yuyz0112
commented on August 22, 2024
If I understand correctly, options like ignoreClassName and blockClassName will be enough right?
from rrweb.
sammdec
commented on August 22, 2024
Yeah that’s correct.
…On 30 Dec 2018, 14:29 +0000, yz-yu ***@***.***>, wrote:
If I understand correctly, options like ignoreClassName and blockClassName will be enough right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
from rrweb.
Yuyz0112
commented on August 22, 2024
It should not be hard to implement, I could add this when I'm free. And if anyone is interested in doing this, I would be glad to help.
from rrweb.
sammdec
commented on August 22, 2024
I would be happy to give it a go tonight. From my understanding I would need a PR to implement in the snapshot repo and this one
…On 30 Dec 2018, 14:32 +0000, yz-yu ***@***.***>, wrote:
It should not be hard to implement, I could add this when I'm free. And if anyone is interested in doing this, I would be glad to help.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
from rrweb.
Yuyz0112
commented on August 22, 2024
Yes you are right, maybe export two functions like getIgnoreClass and getBlockClass from the snapshot repo will make the code cleaner.
from rrweb.
Related Issues (20)
- [Bug]: Uncaught SyntaxError: Regular expression too large HOT 7
- [Bug]: Injected styles are cleared when node is added to a `<style>` element HOT 1
- [Bug]: Duplicate player window
- [Bug]: Seeking within player doesn't correctly handle scrolling HOT 2
- [Bug]: 前端每十秒save的event发送到controller, data要怎样正确拼接才可以正确回放, 现在我只能播放前十秒, 之后因为拼接出错, 一直播放失败
- [Bug]: The player shows canvas in the wrong way HOT 1
- [Bug]: use blockSelector to mask img record will throw error: e.matches is not a function HOT 3
- publish well-formulated and concise types HOT 1
- [Bug]: maskInputFn is not called on inputs
- [feature request]: Record/replay css animation's `currentTime` HOT 6
- [Bug]: progress bar not updating when adding event asynchronously using addEvent
- [Bug]: Added nodes not showing up HOT 1
- Changes the you made may not be saved HOT 1
- [Bug]: CSS `all: unset` incorrectly expands in `events.json` recording HOT 1
- [Bug]: Repeat menu
- [Bug]: Stopping recording causes all insertRule hooks added after record start to drop
- [Bug]: how i can record iframe content HOT 4
- Sanitization/Renaming for Security in Snapshot vs Replay reconstruction HOT 1
- [Bug]: Failed to rebuildFullSnapshot HOT 3
- [Bug]: Firefox Addon causes "This page is asking you to confirm that you want to leave" on all navigation HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rrweb.