Comments (6)
Thanks for the bug report.
When I make a recording of your website via yarn repl
I get the following DOM structure:
{"type":2,
"data":{"node":{"type":0,
"childNodes":[{"type":2,
"tagName":"html",
"attributes":{},
"childNodes":[{"type":2,
"tagName":"head",
"attributes":{},
"childNodes":[{"type":3,
"textContent":"\n\t\t",
"id":4}
And don't get any error.
All of the nodes have an empty attributes
object (your TypeError is complaining about attributes being undefined)
Is it possible that you are doing some server side processing of the rrewb data?
from rrweb.
This would be a fix btw, but don't think it's needed in trunk, but I may be wrong;
+++ b/packages/rrweb-snapshot/src/rebuild.ts
@@ -439,6 +439,7 @@ export function buildNodeWithSN(
// this is needed as document.createElement('iframe') otherwise inherits a CSS1Compat mode from the parent replayer environment
if (
n.childNodes[0].type === NodeType.Element &&
+ n.childNodes[0].attributes &&
'xmlns' in n.childNodes[0].attributes &&
n.childNodes[0].attributes.xmlns === 'http://www.w3.org/1999/xhtml'
) {
from rrweb.
@eoghanmurray Appreciate your response. While recording sessions, I haven't encountered any errors. However, I'm encountering playback issues specifically with rrweb-player, and it seems to be isolated to a particular website. This suggests there might be an issue with how rrweb captures the DOM for this site. Can you please tell if that can be fixed or is there any alternate for this issue.
from rrweb.
So as mentioned I've checked with yarn repl
against the website you referenced but could not recreate.
Could you do the same with your installation of rrweb — 1.0.0-alpha.4 — I'm running off trunk so I think that's a little ahead of you.
General instructions:
Line 30 in 729361e
I also queried whether you are doing any postprocessing of events?
from rrweb.
@eoghanmurray Thank you for your response. I haven't encountered any errors while recording and saving the DOM structure to my backend. However, I'm experiencing issues with playback using rrweb-player. I'll also attempt playback using the trunk version. Regarding post-processing, I'm not currently performing any post-processing on the data.
from rrweb.
Could you let me know what the resolution on this was? Did the current version of trunk fix it?
from rrweb.
Related Issues (20)
- [Bug]: Injected styles are cleared when node is added to a `<style>` element HOT 1
- [Bug]: Duplicate player window
- [Bug]: Seeking within player doesn't correctly handle scrolling HOT 2
- [Bug]: 前端每十秒save的event发送到controller, data要怎样正确拼接才可以正确回放, 现在我只能播放前十秒, 之后因为拼接出错, 一直播放失败
- [Bug]: The player shows canvas in the wrong way HOT 2
- [Bug]: use blockSelector to mask img record will throw error: e.matches is not a function HOT 3
- publish well-formulated and concise types HOT 1
- [Bug]: maskInputFn is not called on inputs
- [feature request]: Record/replay css animation's `currentTime` HOT 6
- [Bug]: progress bar not updating when adding event asynchronously using addEvent
- [Bug]: Added nodes not showing up HOT 1
- Changes the you made may not be saved HOT 1
- [Bug]: CSS `all: unset` incorrectly expands in `events.json` recording HOT 1
- [Bug]: Repeat menu
- [Bug]: Stopping recording causes all insertRule hooks added after record start to drop
- [Bug]: how i can record iframe content HOT 4
- Sanitization/Renaming for Security in Snapshot vs Replay reconstruction HOT 1
- [Bug]: Failed to rebuildFullSnapshot HOT 3
- [Bug]: Firefox Addon causes "This page is asking you to confirm that you want to leave" on all navigation HOT 1
- [Bug]: isParentRemoved lags by 1 to 3 seconds on pages with lots of nodes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rrweb.