Comments (4)
Related - the warning message for math round off
suggests I should use asar 1.9
to fix the deprecation warning. Using asar 1.9
produces:
error: (Einvalid_version_number): Invalid version number. [asar 1.9]
Instead, I need to use asar 1.90
. Is this intended?
from asar.
If I remember correctly, the deprecations are documented in the changelog. Personally, I'd like to avoid adding the deprecation notes to the documentation, since these commands will just disappear entirely from it in Asar 2.0 anyways, so in some sense, this would just be an extra maintenance effort for us with very little benefit. I feel like having just the deprecation warnings and the deprecation notes in the changelog should be enough, but I dunno, maybe other people disagree?
As for the the the "1.9" thing, yeah, I do believe that's an oversight in the warning message and should be fixed. Or maybe more accurately, I'd say this a bug with the asar command itself. IMO, asar 1.9
should compile fine and not throw an error.
from asar.
As a user, I use the documentation as a guideline for how to write asm. It is confusing to me for the documentation to recommend I write my code one way, only to find the tool recommends I write it a different way.
If users are expected to read the changelog to know which features are deprecated, I think you will find that most users won't bother, and there will be a lot of confusion when users try to upgrade, only to find features they are using have been removed. This could be avoided by changing the documentation to make the same recommendation as the assembler (something that needs to be done eventually anyway once the features are removed).
from asar.
I think you will find that most users won't bother, and there will be a lot of confusion when users try to upgrade, only to find features they are using have been removed.
I can definitely see your point here. Though on the other hand: Won't this only be the case when they explicitly ignore warnings given by the assembler? In my opinion, when something goes wrong as the result of consciously ignoring warnings, the fault can only lie with the person doing so. So at least in this specific case, I still wouldn't say the documentation were to blame.
Still, I see your point about how the documentation shouldn't encourage using deprecated functionality, so I do think there's some merit in adding deprecation notes to it. I guess it's primarily a matter of actually doing it, which could be quite time consuming. Ideally, it should also be done in a way that won't cause headaches down the line when merging branches. An alternative solution could be to not add deprecation notes to the manual, but to rather remove all deprecated functionality from the manual outright, which might at least make merges easier (since the newer Asar version would have to delete all those entries from the manual, anyways).
from asar.
Related Issues (20)
- Namescaped incsrc
- Patching to multiple ROMS/files at once
- A command to push/pull/reset all global state
- How to calculate string size? HOT 4
- INC with "non-static" label HOT 9
- Bugs that only troublemakers will find HOT 3
- petition to ban if+endwhile HOT 1
- Segfault on asar_patch when using as a static library HOT 1
- relative branch out of bounds is not checked for SPC700 bbs/bbc commands HOT 1
- `optimize address mirrors` does not handle bank 7E optimization like `ram` does
- org Label in freespace yields too small rats tags HOT 1
- datasize fails when used in assert or print before label is defined HOT 6
- Finding freespace beyond on the end of the ROM only works if the value is 0 HOT 2
- Allow branches to take full addresses HOT 1
- asar_getlabelval throws C++ exception for missing label
- Segfault with invalid syntax in an assert HOT 2
- strange and hard bug about labels and loops, sample code provided
- allow math in labels HOT 15
- arch superfx is haunted HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from asar.