Code Monkey home page Code Monkey logo

Comments (4)

cout avatar cout commented on July 16, 2024

Related - the warning message for math round off suggests I should use asar 1.9 to fix the deprecation warning. Using asar 1.9 produces:

error: (Einvalid_version_number): Invalid version number. [asar 1.9]

Instead, I need to use asar 1.90. Is this intended?

from asar.

RPGHacker avatar RPGHacker commented on July 16, 2024

If I remember correctly, the deprecations are documented in the changelog. Personally, I'd like to avoid adding the deprecation notes to the documentation, since these commands will just disappear entirely from it in Asar 2.0 anyways, so in some sense, this would just be an extra maintenance effort for us with very little benefit. I feel like having just the deprecation warnings and the deprecation notes in the changelog should be enough, but I dunno, maybe other people disagree?

As for the the the "1.9" thing, yeah, I do believe that's an oversight in the warning message and should be fixed. Or maybe more accurately, I'd say this a bug with the asar command itself. IMO, asar 1.9 should compile fine and not throw an error.

from asar.

cout avatar cout commented on July 16, 2024

As a user, I use the documentation as a guideline for how to write asm. It is confusing to me for the documentation to recommend I write my code one way, only to find the tool recommends I write it a different way.

If users are expected to read the changelog to know which features are deprecated, I think you will find that most users won't bother, and there will be a lot of confusion when users try to upgrade, only to find features they are using have been removed. This could be avoided by changing the documentation to make the same recommendation as the assembler (something that needs to be done eventually anyway once the features are removed).

from asar.

RPGHacker avatar RPGHacker commented on July 16, 2024

I think you will find that most users won't bother, and there will be a lot of confusion when users try to upgrade, only to find features they are using have been removed.

I can definitely see your point here. Though on the other hand: Won't this only be the case when they explicitly ignore warnings given by the assembler? In my opinion, when something goes wrong as the result of consciously ignoring warnings, the fault can only lie with the person doing so. So at least in this specific case, I still wouldn't say the documentation were to blame.

Still, I see your point about how the documentation shouldn't encourage using deprecated functionality, so I do think there's some merit in adding deprecation notes to it. I guess it's primarily a matter of actually doing it, which could be quite time consuming. Ideally, it should also be done in a way that won't cause headaches down the line when merging branches. An alternative solution could be to not add deprecation notes to the manual, but to rather remove all deprecated functionality from the manual outright, which might at least make merges easier (since the newer Asar version would have to delete all those entries from the manual, anyways).

from asar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.