Comments (6)
Original comment by [email protected]
on 24 Feb 2012 at 11:53
- Changed state: Accepted
from daisydiff.
If the streams are closed properly the issue goes away?
Have you already fixed it yourself? Do you have a patch?
Original comment by [email protected]
on 24 Feb 2012 at 3:45
- Changed state: Started
from daisydiff.
I move the initialization of oldStream and newStream object outside the
try->catch->block
....
String[] css = new String[]{};
InputStream oldStream = null;
InputStream newStream = null;
....
and add a finally block
finally {
try {
if(oldStream != null) oldStream.close();
} catch (IOException e) {
//ignore this exception
}
try {
if(newStream != null) newStream.close();
} catch (IOException e) {
//ignore this exception
}
}
furthermore it would be helpful to rewrite Line 167-169
InputStreamReader oldReader = null;
BufferedReader oldBuffer = null;
InputStreamReader newISReader = null;
BufferedReader newBuffer = null;
try {
oldReader = new InputStreamReader(oldStream);
oldBuffer = new BufferedReader(oldReader);
newISReader = new InputStreamReader(newStream);
newBuffer = new BufferedReader(newISReader);
DaisyDiff.diffTag(oldBuffer, newBuffer, postProcess);
} catch (Exception e) {
System.out.println(e);
} finally {
oldBuffer.close();
newBuffer.close();
oldReader.close();
newISReader.close();
}
Original comment by [email protected]
on 24 Feb 2012 at 11:33
from daisydiff.
Can you perform a diff on your code to create a patch and post it here? I will
apply it to trunk after testing.
Original comment by [email protected]
on 25 Feb 2012 at 9:39
from daisydiff.
A local test shows, that this will prevent a resource blocking problem.
Original comment by [email protected]
on 27 Feb 2012 at 4:41
Attachments:
from daisydiff.
Fixed in subversion r175
Original comment by [email protected]
on 27 Feb 2012 at 8:59
- Changed state: Fixed
from daisydiff.
Related Issues (20)
- Add location of css and js directories as a commandline option HOT 1
- Indentation goes crazy when you compare two html pages having lot of numbered lists HOT 2
- Indentation goes crazy when you compare two html pages having lot of numbered lists HOT 4
- Alternative jQuery UI for Diff results
- Daisydiff fails to process certain invalid HTML files HOT 9
- DOM structure is modified in the daisydiff output HOT 5
- Unit test fails due to a missing newline character HOT 2
- Empty IMG tag throws NullPointerException
- when we comparing the two files have no change, daisy diff throwing Uncaught unknown destination..
- Does not Diff <Title> or <Meta> or <JavaScript> in HTML HOT 3
- An element that was moved out of a table can lead to broken table elements in the diff HOT 1
- Invalid tags are generated HOT 2
- Word changed but showing removed and added & change in image showing improper in Chrome. HOT 1
- error on line 6 at column 8: Opening and ending tag mismatch: link line 0 and head HOT 8
- [deleted issue]
- Compare result error for table
- [deleted issue]
- TextNode->IsSame() references not declared variable $html2 in php
- Is it possible to display the new created content? Not display the whole line.
- Xerces Impl included in daisydiff.jar has security vulnerabilities
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from daisydiff.