Code Monkey home page Code Monkey logo

Comments (6)

rpaw053 avatar rpaw053 commented on July 23, 2024

Bug fix done and the updated code is present on GH-94

by rpaw053

from nz-orcid-hub.

rpaw053 avatar rpaw053 commented on July 23, 2024

TODO: Bugs fixes:
1) While adding the employment details if user doesn’t not supplies non-compulsory fields such as ‘State/region’, ‘Department’ and ‘Role’, then user gets error “Failure to update %s”.
2) While accessing the employment details page for e.g. https://dev.orcidhub.org.nz/16/emp/new if any admin manually changes the url to https://dev.orcidhub.org.nz/29/emp/new and if there is record present for that url then the Org admin is able to access the link even if he is not the org admin for that record.
3) The created-date and last-modified-date is set to date 1970-01-18, have to fix that.

by rpaw053

from nz-orcid-hub.

rpaw053 avatar rpaw053 commented on July 23, 2024

Bug/Error:

1/ with only having give a read-limited token, access to the emp/new form is prevented. Expected behaviour
2/ relinking and allowing write access creates the necessary token and gives access to the form but...
3/ when Saving the new employment it fails with the error: "Failed to update the entry: ORCID could not process the data, because they were invalid.. You don't have required permission to edit the record.", suggesting the read-limited token, and not the write token was used.

NB: "You have already given read and write permissions to..."

by jgus614

from nz-orcid-hub.

rpaw053 avatar rpaw053 commented on July 23, 2024

Implementation related to this issue is completed.

by rpaw053

from nz-orcid-hub.

rpaw053 avatar rpaw053 commented on July 23, 2024

Code changes are done and checked in under branch GH-54_GH-9, Code review, code improvement and unit testing is in progress.

by rpaw053

from nz-orcid-hub.

rpaw053 avatar rpaw053 commented on July 23, 2024

For this user story, the researcher would be authorized to grant write access to research organisation the important thing we require is client id and client secret code of research organisation(we need to think about how to get client id and secret code for all on boarded organisations).

We are required to write an API that will redirect the researcher to the page which will ask him to grant access to research organisation.

by rpaw053

from nz-orcid-hub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.