Code Monkey home page Code Monkey logo

Comments (5)

wucke13 avatar wucke13 commented on May 28, 2024

libsodium is linked using pkg-config, so there it should be easy to replace it as wished when packaging for a distro. With liboqs, no chance. The liboqs-sys crate does ship its own vendored version of oqs and AFAICT doesn't offer to override the version used. So as I see it, there is nothing we can do from the rosenpass side. Feel free to re-open the issue if you disagree!

from rosenpass.

clausecker avatar clausecker commented on May 28, 2024

I do disagree! Maybe this issue should be raised with the liboqs crate instead.

from rosenpass.

wucke13 avatar wucke13 commented on May 28, 2024

Please go for it :) I'm eager to see what they think. I'm with you that it makes sense to allow the packagers to choose how deps are satisfied, however for a young project (with potential API & ABI breakage) it might make sense that the bindings they ship come with exactly one specific version of the respective C code. That surely avoids all different weird kind of bugs.

from rosenpass.

clausecker avatar clausecker commented on May 28, 2024

I'm more interested in avoiding the bug where there's a CVE we patched in the liboqs port but not in your project because you bundle your own static copy.

from rosenpass.

clausecker avatar clausecker commented on May 28, 2024

See this bug report: open-quantum-safe/liboqs-rust#190

from rosenpass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.