Changing to DST at wrong time. about eztime HOT 3 CLOSED

I had a similar case of brain hurt trying to hunt down an issue that is probably the same thing (#15), but the swap with minutes and hours is fascinating and may be the best clue yet. I will take a look soon, there's clearly some bigger work to be done...

from eztime.

OK, did a bit of debugging.

In Timezone::tzTime, std_offset and dst_offset are assigned minutes:

int16_t std_offset = (offset_hr < 0) ? offset_hr * 60 - offset_min : offset_hr * 60 + offset_min;

But, later they're treated as seconds. So, fixing that:

	if (local_or_utc == UTC_TIME) {
		dst_start -= std_offset * 60LL;
		dst_end -= dst_offset * 60LL;
	}

Makes things more sane, it's now changing by 5 hours instead of 5 minutes. But, the signs are also wrong... Fixing that makes it:

	if (local_or_utc == UTC_TIME) {
		dst_start += std_offset * 60LL;
		dst_end += dst_offset * 60LL;
	}

All fixed. (I think??) You'll have to verify (works for me now), and roll it in.

Edit: references to "olsen" should be changed to "olson", to respect the creator, Arthur David Olson.

from eztime.

Fixed by commit a81250a from #29 (thanks!!)

from eztime.