Comments (3)
I had a similar case of brain hurt trying to hunt down an issue that is probably the same thing (#15), but the swap with minutes and hours is fascinating and may be the best clue yet. I will take a look soon, there's clearly some bigger work to be done...
from eztime.
OK, did a bit of debugging.
In Timezone::tzTime, std_offset and dst_offset are assigned minutes:
int16_t std_offset = (offset_hr < 0) ? offset_hr * 60 - offset_min : offset_hr * 60 + offset_min;
But, later they're treated as seconds. So, fixing that:
if (local_or_utc == UTC_TIME) {
dst_start -= std_offset * 60LL;
dst_end -= dst_offset * 60LL;
}
Makes things more sane, it's now changing by 5 hours instead of 5 minutes. But, the signs are also wrong... Fixing that makes it:
if (local_or_utc == UTC_TIME) {
dst_start += std_offset * 60LL;
dst_end += dst_offset * 60LL;
}
All fixed. (I think??) You'll have to verify (works for me now), and roll it in.
Edit: references to "olsen" should be changed to "olson", to respect the creator, Arthur David Olson.
from eztime.
Fixed by commit a81250a from #29 (thanks!!)
from eztime.
Related Issues (20)
- NTP update time violates NTP.org guidelines HOT 2
- WDT Reset when multiple setTimeZone() calls time out HOT 1
- How to tell if NTP has been successfully update after manually setting time with setTime HOT 2
- Idea : Improve accuracy aiming sub millisecond HOT 9
- FritzBox Router sends wrong ntp packet
- Library ignores if EERPROM is already being used
- Use SPIFFS for caching timezone? HOT 1
- Inspiration: Color Clock HOT 1
- hour() is off when passing in a timestamp, or I'm using it wrong? HOT 2
- can't set time zone for Asia/Tehran
- Improving library features
- Asia/Jerusalem returns empty posix string HOT 1
- readme update for "different languages"
- examples Timezones.ino proposed enhancement - thanks
- Dublin timezone incorrect time HOT 1
- 'myTZ was not declared in this scope'
- Feature request
- day(t) seems to return incorrect value
- Using ezTime with nodemcu-32s w/64x32 HUb75 LED Matrix HOT 5
- Stack problem whtn activate the waitForSync
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eztime.