future_lapply() in future package is deprecated about robotstxt HOT 11 CLOSED

get_robotstxts("https://google.com", use_futures = T) gives a warning with version 1.8.1 of future: The implementation of future_lapply() in the 'future' package has been deprecated. Please use the one in the 'future.apply' package instead. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#24>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5Ug9m82UCN_G8o91CTaGLjm50q1BA9ks5tyZjTgaJpZM4T98Bk> .

Yep, just wanted to notify you of the warning. It seems to me that simply adding future.apply as an import and changing this line: https://github.com/ropenscilabs/robotstxt/blob/8b48acc7ccb617308e7ed288840fd7bdb76cc6d2/R/get_robotstxts.R#L61 should resolve the issue. However, I'm not familiar with the futures package, and since those lines are not covered by a test, I'd rather not change it myself 🙃 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5Ugwh-6IP2h_YeHqCsWzpMy8VJXdMXks5tyZ9-gaJpZM4T98Bk> .

FYI, I'm about to release future 1.9.0 where this will break with: checking re-building of vignette outputs ... WARNINGError in re-building vignettes: ...Quitting from lines 48-51 (using_robotstxt.Rmd) Error: processing vignette 'using_robotstxt.Rmd' failed with diagnostics:The implementation of future_lapply() in the 'future' package is defunct. Please use the one in the 'future.apply' package instead.Execution halted — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5Ug5leBBPrs-mVVjS1sGMbxGO7iPrLks5uEMx_gaJpZM4T98Bk> .

On Sat, Jul 7, 2018, 14:16 Peter Meissner ***@***.***> wrote: Thanks, what's the timetable? Henrik Bengtsson ***@***.***> schrieb am Sa., 7. Juli 2018, 16:58: > FYI, I'm about to release future 1.9.0 where this will break with: > > checking re-building of vignette outputs ... WARNINGError in re-building vignettes: > ...Quitting from lines 48-51 (using_robotstxt.Rmd) Error: processing vignette 'using_robotstxt.Rmd' failed with diagnostics:The implementation of future_lapply() in the 'future' package is defunct. Please use the one in the 'future.apply' package instead.Execution halted > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#24 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AA5Ug5leBBPrs-mVVjS1sGMbxGO7iPrLks5uEMx_gaJpZM4T98Bk > > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABir0tNTkJodI8Zbn4Xg7cb7xeBugHu5ks5uESUYgaJpZM4T98Bk> .

A couple of weeks is my hope. On Sat, Jul 7, 2018, 14:16 Peter Meissner ***@***.***> wrote: > Thanks, what's the timetable? > > Henrik Bengtsson ***@***.***> schrieb am Sa., 7. Juli 2018, > 16:58: > > > FYI, I'm about to release future 1.9.0 where this will break with: > > > > checking re-building of vignette outputs ... WARNINGError in re-building > vignettes: > > ...Quitting from lines 48-51 (using_robotstxt.Rmd) Error: processing > vignette 'using_robotstxt.Rmd' failed with diagnostics:The implementation > of future_lapply() in the 'future' package is defunct. Please use the one > in the 'future.apply' package instead.Execution halted > > > > — > > You are receiving this because you commented. > > Reply to this email directly, view it on GitHub > > < #24 (comment) > >, > > or mute the thread > > < > https://github.com/notifications/unsubscribe-auth/AA5Ug5leBBPrs-mVVjS1sGMbxGO7iPrLks5uEMx_gaJpZM4T98Bk > > > > . > > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#24 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/ABir0tNTkJodI8Zbn4Xg7cb7xeBugHu5ks5uESUYgaJpZM4T98Bk > > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5Ugw-viuh-jvdimwlhx0gJD5SMGupMks5uESeggaJpZM4T98Bk> .

Yes, thxs. And it now passes future's revdep tests - ***@***.*** <HenrikBengtsson/future@9f67c57> — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5Ug1190PK_f3O77O3rWwsUi9vuKKviks5uIGv8gaJpZM4T98Bk> .