`calc_vis_angle()` development and bug fixes about pathviewr HOT 2 CLOSED

We forgot to update this thread after our meeting. Just some quick notes from last week:

• The root cause of the "bug" was that I had misunderstood the way Eric had set up the vertex_angle argument -- I had assumed it was the angle between the two screens themselves rather than the angle between one screen and a vertical plane through the vertex. I knew it had to be something like this! In any case, this was my bad. So the angles etc are all calculated correctly within calc_vis_angle().
• We discussed the pros and cons of calculating a "visual angle", and how it conveys info about the stimulus when the stimulus is centered around the min_dist between the screen and the subject. We'll need to be explicit in the documentation etc about what a "visual angle", when computed this way, tells us.
• We also discussed how modulation of spatial frequency itself can be calculated using the min_dist that Eric was already calculating. This is similar to the way in which Graham & Dre have calibrated spatial frequencies appropriately during their e-phys experiments by incorporating the distance between the bird & screen as well as the dimensions of the stimuli (e.g. in pixels). I gave Eric some Matlab scripts that Graham had been using for his e-phys stimuli. Eric has started writing this spatial frequency calculation function as a separate function.
• We're both stabbing our way through plotting. We now have some code to approximate the positions of the screens based on the inputs from these functions. From these (and the actual dimensions of the TV screens), we can try to figure out the coordinates of all corners of the tunnel, with the hope of 3D plotting all this in rgl ultimately
• Eric will also take a stab at a add_treaments() function (or something with a similar name) to add in treatment labels (as a column in the tibble) as well as additional metadata such as vertex (or tunnel) coordinates and stimulus parameters as attributes.

from pathviewr.

Hey @epress12 , when you get a chance can you please add details to https://github.com/vbaliga/pathviewR/blob/3d6b6e3746788c7a5a794866be6ec9f186ab06b0/R/analytical_functions.R#L369

No big deal -- it just popped up on a devtools::check() that the roxygen for this function was missing one of its parameter arguments. I inserted temporary dummy text just so the check would pass.

from pathviewr.