Planned re-launch of comtradr about comtradr HOT 6 CLOSED

I propose that for now, we focus on only the options for the free API.

Agree!

I think we can probably just use two simple functions proposed in the httr2 package for setting and getting the token that are relatively user friendly, e.g. like here: https://github.com/datapumpernickel/untrader/blob/main/R/utils.R

Agree!

My proposal would be to further modularize this function to make it easier to trouble-shoot, make it easy to extend specific parts of it (e.g. adding new parameters) and work on it in parallel without conflicts.

Agree! The current structure provided in untrader is great. There are some changes in syntax on the API end that need to be added. I have a live list of these. They are very easy to incorporate.

The full list of reference tables can be found here: https://comtradeapi.un.org/files/v1/app/reference/ListofReferences.json
It would probably make sense to write a function that queries all of these in some smart fashion and saves them in extdata.

Agree! And I have existing functions that do this. I can add them in the dev branch and we can see how they run.

I think it would be good to make these available to the user as well and not keep them internal, at least I found myself frequently looking at them.

Also agree.

I would propose we abandon the writing out of country names, because it is very error prone.

Agree. We can add some instructions in a vignette that provide users with easy access to countries' ISO3 codes using countrycode.

from comtradr.

Comtradr has been fully reviewed and submitted to CRAN. Let/s hope this works out, but closing this issue, as the relaunch in terms of functions itself is finished. See #68 for future development goals.

from comtradr.

Regarding saving data,

• I wrote https://blog.r-hub.io/2021/07/30/cache/
• In another package a co-author and I made the choice to save data in an app dir, and at each session (that call is memoised) download the data if possible (to have a fresher copy) or use the cache if not. That might not be a good choice for you depending on how often the upstream data is updated. EMODnet/EMODnetWFS#153

from comtradr.

Is there any policy on this @maelle?

Good question! ropensci/software-review-meta#100

from comtradr.

Hello, on the badges in the README, none of those are actually essential. If the package stays within the rOpenSci GH org, I assume they will want to keep that badge on the repo. Honestly, I think this was my first time adding badges to any repo I built, so I added a bunch because I thought they looked cool :) But, the CI/CD integrations do provide some value. I found those useful because I was developing on a Mac locally, so seeing that new updates I was pushing would successfully build and install on osx/linux/windows was helpful.

Travis: This was set up to build and install comtradr on osx and linux. You'll need to re-authenticate the package on the Travis platform to get this working again.

AppVeyor: This was set up to build and install comtradr on Windows (I think?). Same with Travis-CI, you'll need to re-authenticate the package to get this working again.

CodeCov: This just shows the percentage of source code that's covered by unit tests. Again, comtradr needs to be reauthenticated.

CRAN: I think this can be left as-is. Since this package was on CRAN for years, I think it's beneficial to display the current CRAN status.

from comtradr.

Travis: This was set up to build and install comtradr on osx and linux. You'll need to re-authenticate the package on the Travis platform to get this working again.

AppVeyor: This was set up to build and install comtradr on Windows (I think?). Same with Travis-CI, you'll need to re-authenticate the package to get this working again.

CodeCov: This just shows the percentage of source code that's covered by unit tests. Again, comtradr needs to be reauthenticated.

Thanks @ChrisMuir for the input. We will look into re-authenticating them then once we have evolved to where the package should pass checks again! And yes, I do get the appeal of adding lots of badges. :P

CRAN: I think this can be left as-is. Since this package was on CRAN for years, I think it's beneficial to display the current CRAN status.
Yes, agree!

from comtradr.