[bug] `bud-cache` skips assets emitted by plugins about bud HOT 6 CLOSED

At first glance it looks like the loader needs to declare its dependencies.

For example, this is how bud.js handles extracting @asset directive in blade source files: https://github.com/roots/bud/blob/main/sources/%40roots/blade-loader/src/asset-loader.cts#L15

The dependency has to be added explicitly otherwise there is no relationship established in the graph (the emitted css is treated as unrelated to the originating source files).

Relevant docs:

• https://webpack.js.org/api/loaders/#thisadddependency
• https://webpack.js.org/api/loaders/#thisaddmissingdependency

I'll confirm later and will issue a PR if I'm correct.

from bud.

I issued a couple PRs:

• talss89/wp-editor-query-plugin#1
• talss89/wp-editor-query-plugin#2

The first just adds a single line to the loader which marks it as not supporting caching, which fixes the issue. Maybe kind of brute force but it does the trick. I had trouble with other approaches.

The second is a broader refactor that removes the plugin & store modules in favor of doing all the work in the loader. This is easily cacheable and behaves nominally.

This would be the core of the suggestion:

  postcss([extract])
    .process(source, { from: parsed.base })
    /**
     * Extract the editor specific css from the source file
     * and emit it as a separate file
     */
    .then((extracted) => {
      const emitPath = join(`editor`, parsed.base);
      this.emitFile(emitPath, extracted.toString(), false);


      /**
       * Remove the editor specific css from the source file
       * and return the result
       */
      postcss([remove])
        .process(source, { from: parsed.base })
        .then((result) => {
          callback(null, result.toString());
        });
    });

from bud.

Thanks for the input on this @strarsis and @kellymears. I've rewritten the plugin as a bud extension using the loader-only approach, and simplified things a lot.

It's at https://github.com/talss89/bud-wp-editor-query

From my POV, happy to close this issue. 🍻

from bud.

Yes, with the bud plugin everything works great out of the box.

from bud.

Great! I'll have a look at both approaches.

I agree with you, if we can do it all in the loader, then that's the way to go. I'm not sure how 'collecting' rules from multiple modules and emitting one asset will work though.

I really appreciate the time / effort you've put in. Thank you!

from bud.

I was assuming modules would be concatenated since by this point sass/postcss has already processed everything, so local import declarations will have already been replaced.

If this is not a good assumption (it might not be) then yeah, my approach will be a little lacking as-is.

from bud.