Agreement <input type

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

[bug] Unable to generate source maps with Sage about bud HOT 2 CLOSED

kupoback commented on August 25, 2024

[bug] Unable to generate source maps with Sage

from bud.

Comments (2)

kellymears commented on August 25, 2024

I am now required to install @roots/bud-sass despite before bud was compiling SCSS with no issues.

I'm so sorry for this injustice.

Expected behavior

A source-map generated for the SCSS files.

Why did you expect that behavior?

Sage isn't configured to generate a source-map in production, only development. If you want to configure it differently you can use bud.devtool or the --devtool flag with the bud build command.

The function has 100% test coverage and works fine:

bud/sources/@roots/bud-api/src/methods/devtool/devtool.test.ts

Lines 12 to 47 in 6b7d63d

    
           beforeEach(async () => { 
        
             bud = await factory() 
        
             bud.hooks.on = callback 
        
             method = devtool.bind(bud) 
        
             vi.clearAllMocks() 
        
           }) 
        
           it(`is a function`, () => { 
        
             expect(method).toBeInstanceOf(Function) 
        
           }) 
        
           it(`returns bud`, async () => { 
        
             const ret = await method() 
        
             expect(ret).toBe(bud) 
        
           }) 
        
           it(`calls bud.hooks.on`, async () => { 
        
             const onSpy = vi.spyOn(bud.hooks, `on`) 
        
             await method() 
        
             expect(onSpy).toHaveBeenCalledTimes(1) 
        
           }) 
        
           it(`calls bud.hooks.on`, async () => { 
        
             const onSpy = vi.spyOn(bud.hooks, `on`) 
        
             await method() 
        
             expect(onSpy).toHaveBeenCalledWith( 
        
               `build.devtool`, 
        
               `cheap-module-source-map`, 
        
             ) 
        
           }) 
        
           it(`calls bud.hooks.on with expected arguments`, async () => { 
        
             const onSpy = vi.spyOn(bud.hooks, `on`) 
        
             await method(callback) 
        
             expect(onSpy).toHaveBeenCalledWith(`build.devtool`, callback) 
        
           })

from bud.

kupoback commented on August 25, 2024

@kellymears Okay, so looking at it, I need to update my build script to run as development, and then add some filters so that it doesn't use BrowserSync. Reason I mention this is that we have development sites, and our Frontend developers need to reference SCSS files, despite it not being needed for a final production.

from bud.

Recommend Projects

[bug] Unable to generate source maps with Sage about bud HOT 2 CLOSED

Comments (2)

Expected behavior

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	beforeEach(async () => {
	bud = await factory()
	bud.hooks.on = callback
	method = devtool.bind(bud)
	vi.clearAllMocks()
	})

	it(`is a function`, () => {
	expect(method).toBeInstanceOf(Function)
	})

	it(`returns bud`, async () => {
	const ret = await method()
	expect(ret).toBe(bud)
	})

	it(`calls bud.hooks.on`, async () => {
	const onSpy = vi.spyOn(bud.hooks, `on`)
	await method()
	expect(onSpy).toHaveBeenCalledTimes(1)
	})

	it(`calls bud.hooks.on`, async () => {
	const onSpy = vi.spyOn(bud.hooks, `on`)
	await method()
	expect(onSpy).toHaveBeenCalledWith(
	`build.devtool`,
	`cheap-module-source-map`,
	)
	})

	it(`calls bud.hooks.on with expected arguments`, async () => {
	const onSpy = vi.spyOn(bud.hooks, `on`)
	await method(callback)
	expect(onSpy).toHaveBeenCalledWith(`build.devtool`, callback)
	})