Comments (2)
I'm willing to hear out arguments for the behavior being different, but this function is working as intended (and as documented).
It gives you the object and asks you to return something:
export interface Mutator {
(
json:
| Partial<Theme.GlobalSettingsAndStyles['settings']>
| Container<Partial<Theme.GlobalSettingsAndStyles['settings']>>,
):
| Partial<Theme.GlobalSettingsAndStyles['settings']>
| Container<Partial<Theme.GlobalSettingsAndStyles['settings']>>
}
interface settings {
(
input?:
| Mutator
| Container<Partial<Theme.GlobalSettingsAndStyles['settings']>>
| Partial<Theme.GlobalSettingsAndStyles['settings']>
| boolean,
raw?: boolean,
): this
}
I think it's more confusing for this function to not use what is returned as a value. And it's pretty easy to always return a value with arrow fns and the container interface:
bud.wpjson.settings(theme => theme
.set('color.custom', false)
.set('color.customDuotone', false)
)
Regardless, wpjson.settings
should arguably be deprecated in #2079 (currently not planning on that). But, I would use bud.wpjson.set
over bud.wpjson.settings
(PR soon on sage itself):
bud.wpjson
.set(`settings.color.custom`, false)
.set(`settings.color.customDuotone`, false)
.set(`settings.color.customGradient`, false)
.set(`settings.color.defaultDuotone`, false)
from bud.
Message to comment on stale issues. If none provided, will not mark issues stale
from bud.
Related Issues (20)
- [bug] v6.19.0: `Could not import @roots/bud-framework/env` HOT 1
- [bug] assets not compiling + hmr not working in dev after 6.18.0 HOT 9
- [bug] globby@14 requires node 18
- feat(tailwindcss): ❤️ ⬆️ bump tailwindcss to 3.4 HOT 3
- [request] Equivalent of TW's @apply() for bud.wpjson.setStyles()
- [request] Separate TailwindCSS bundle for each entry point HOT 6
- [bug] bud-sass/stylelint-config in incompatible with WP naming HOT 2
- [request] document @roots/bud-preset-wordpress/stylelint
- [bug] dynamic imports doesn't work with extracted WordPress dependencies HOT 4
- [bug] Can't change URL of dev server HOT 3
- [bug] create-bud-app: Stylelint errors "place-content" HOT 2
- [bug] create-bud-app always builds TS project even if option is un-checked HOT 3
- [bug] `media-query-no-invalid` fails for tailwind `@media screen() {}` HOT 2
- [bug] bud.js not working with Stylelint 16.x HOT 1
- [bug] Issue with Usage code snippet in Managing theme.json Docs
- [bug] bud-react not triggering react-refresh HOT 1
- [bug] S3 upload fails after first upload when `source` and `destination` are set
- [bug] Cannot read properties of null (reading 'useState') HOT 12
- Upgrade vulnerable deps: webpack-dev-middleware (<6.1.2) HOT 2
- Tailwind logical properties classes does not work as expected HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bud.