[Question] are contributions in kotlin welcome? about voipussd HOT 11 CLOSED

Hi @ducaale
are contributions in kotlin welcome? yes, i build a new branch kotlin, just create a pull request into 'kotlin branch'!

from voipussd.

Hi @ducaale , i migrate into kotlin... check the branch kotlin

from voipussd.

HI @romellfudi, i think it would be better if you added kotlin support as a module like in https://github.com/florent37/RuntimePermission instead of it being a separate repo/library

from voipussd.

Hi @ducaale, you always can use it(RuntimePermission).
My permission library is NOT into VoidUSSD module, that is the reason everyone could use whatever permission library into 'My App Project'

from voipussd.

HI @romellfudi, no, what i meant is how some library authors structure their library into seperate modules.

from voipussd.

I understand you. Mmm please an example?😅 But In this project just use one module

Sent from my Galaxy S8+ using FastHub

from voipussd.

Hi @romellfudi, for example in https://github.com/florent37/RuntimePermission they wrote their core library in java and added convenient extensions for kotlin in a separate module so they have:

• runtime-permission (written in java)
• runtime-permission-kotlin (dependent on runtime-permission and written in kotlin)

IMHO i think maintaining the same library in two languages is a bit hard. so my opinion would be to leave the core of VoIpUSSD as it is written in java and add kotlin extensions as needed in a separate module

from voipussd.

Hello mr.@ducaale , thanks a lot. its a great idea... I might do it. HOHO (definitely will do it), I have already learnt kotlin since 3 days. 😅
But right now i have not much time.
Probability in a couple of weeks or months,
if you could help me and just merge the master branch of KotlinVoipUSSD(usdd-library module) with this master(VoipUSSD), like:

• ussd-library
• ussd-library-kotlin (rename) or kotlin-ussd-library

Join them, just be carefully with unit tests
Finally made a pull request, i'd appreciate it

from voipussd.

ok no problem, i will see what i can do

from voipussd.

Hi @ducaale , I'll start to merge

Sent from my Galaxy S8+ using FastHub

from voipussd.

Hi @ducaale , i've done

from voipussd.