Comments (9)
Hey @bjohnso5 and @juanantoniocid, let me look into this.
from rollbar-go.
The New()
function defined in client.go
is intended to return the default implementation of a Client, but then you return a value whose type is not exported. It has broken our code (it is supposed a patch version change shouldn't break anything).
What is the purpose of New()
if it is not used internally and the returned value is not exported?
from rollbar-go.
I think the idea was to use rollbar package directly (from rollbar.go) without instantiating the Client directly. So to me, using exported methods from rollbar.go together with exported methods from client.go does not make much sense. But if a lot of people are using Client directly and skip the stuff from rollbar.go then I am willing to revert the change and rerelease.
from rollbar-go.
I have reverted the change for private client and rereleased v1.4.3. Sorry about that breaking change, I guess my assumption was incorrect and it's too late to change anything now.
from rollbar-go.
closing for now, but please let me know if there are any problems. thank you
from rollbar-go.
I have reverted the change for private client and rereleased v1.4.3. Sorry about that breaking change, I guess my assumption was incorrect and it's too late to change anything now.
No worries @pawelsz-rb and thanks a lot for handling it so fast!
from rollbar-go.
@pawelsz-rb I think we might need a new 1.4.4 release to actually propagate this change, when I clear my go mod cache and re-download 1.4.3, I still get the version with the unexported rollbar.client
struct
from rollbar-go.
That's correct, it's basically impossible to re-release a Go module version (Google's module cache prevents it)
from rollbar-go.
v1.4.4 released, thx!
from rollbar-go.
Related Issues (20)
- Prevent rollbar-go to start a Client by default HOT 1
- SetPlatform is overloaded
- Unexported function on the Transport interface prevents mocking HOT 1
- Consider tagging submodule "errors"? HOT 1
- IP Logging should not depend on client knowing the remote IP address HOT 2
- Any example for adding rollbar to serverless ? HOT 1
- set a new transport HOT 1
- Take advantage of new Go 1.13 Unwrap method HOT 1
- Confusion around Wait() function HOT 6
- Bug: `LambdaWrapper` panics at runtime when panic occurs inside a lambda handler with multiple return values
- Stop hacker's from thefting HOT 5
- Unclear how to send messages with custom client instance HOT 2
- Segfault when using client HOT 2
- client/transport.Close() does not support context HOT 4
- Will you release this pkg anymore? HOT 3
- 422 Unprocessable Entity after Upgrading to v1.4.2 HOT 2
- Add support for FluentD HOT 1
- Async transpot can panic HOT 2
- Unable to get IP addresses in gin middleware. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rollbar-go.