`Model.WorldPivotData` needs a custom property setter/getter about rbx-dom HOT 2 CLOSED

So... there's a complication I discovered while implementing this.

For the custom property getter/setter to work for Rojo, we also need to add an encoder/decoder for OptionalCFrame, like in #179. The problem is that OptionalCFrame can be None, which is serialized to JSON like this:

{ "OptionalCFrame": null }

Roblox's HttpService:JSONDecode decodes this as an empty Lua table, which breaks the assumption that all property value tables contain a key-value pair.

This can be worked around by treating an empty table as an unoccupied optional value. I'm open to other approaches though!

from rbx-dom.

Intuition says it'd be fine to treat an empty table as a sentinel value.

In practical terms, I only see this being a problem if Roblox adds other optional types down the line and we just start using one underlying type for it and there's some other use for {} as a real value for one of the optional types. Which is to say, there won't be an issue as long as we don't do anything dumb.

from rbx-dom.