issue with `const` keyword about sphinx-csharp HOT 9 CLOSED

wow, thanks (and for the super quick response)!

btw, i also created an issue for breathe and added a ref here

from sphinx-csharp.

Firstly, I haven't looked at this code in a while.

sphinx-csharp should detect the const as a keyword. The doxygen output seems fine. My hunch is that breathe is somehow adding the static and assuming there is only one keyword.

I should really add some tests for the doxygen/breathe integration, will have a look at this...

from sphinx-csharp.

This issue is similar to #2, except that const is a vaild C# keyword.

from sphinx-csharp.

I used breathe>=4.19.2 last time in https://github.com/rogerbarton/vr-modeling/blob/master/docs/requirements.txt. There may be issues when you use breathe=4.30.0

from sphinx-csharp.

After some debugging I think the issue is in these lines:
https://github.com/michaeljones/breathe/blob/d8add71c4613f6073928ad221400241407c17eb3/breathe/renderer/sphinxrenderer.py#L1995-L2033

and the static is added because of:
https://github.com/michaeljones/breathe/blob/d8add71c4613f6073928ad221400241407c17eb3/breathe/renderer/sphinxrenderer.py#L2008-L2009

I will see if I can fix this

from sphinx-csharp.

I think if you use git+https://github.com/rogerbarton/breathe.git@dev in your requirements.txt it should work for now.

from sphinx-csharp.

Can you try using pip install git+https://github.com/rogerbarton/breathe.git@dev and then running it again. I think rogerbarton/breathe@fc0d085 should have fixed the issue.

from sphinx-csharp.

Perfect, thanks for the quick fix! Works like a charm now :)

The constants are still listed under static attributes, however I think this is fine since they are indeed implicitly static.

from sphinx-csharp.

Awesome glad it works, I will now create a merge request for the breathe repo...

from sphinx-csharp.