Code Monkey home page Code Monkey logo

Comments (8)

rogden avatar rogden commented on June 29, 2024

Hi @jalemy ! Thank you for the feedback and I am glad you are getting value from the tool!

Adding support for changing out the example sentence used for the font sections is a great idea. I think the following would do the trick:

  1. Add a new config setting for the sentence:
module.exports = {
  theme: {
    configViewer: {
      typographyExample: 'Your example sentence'
    }
  }
}
  1. Each component in src/components/Canvas/Sections is passed the entire config if you add it as a prop. You can add the config prop it to the various font sections and output the example sentence from it if set. If it isn't set, output the default.

This should be a quick change. I'm happy to make it but if you'd like to contribute via a PR that would be great. Let me know.

from tailwind-config-viewer.

jalemy avatar jalemy commented on June 29, 2024

Thank you for advice<3

I will issue a pull request soon.

from tailwind-config-viewer.

jalemy avatar jalemy commented on June 29, 2024

@rogden
I don't seem to have write permission to this repository, and I can't create a pull request.
Can you please give me write permission?

from tailwind-config-viewer.

rogden avatar rogden commented on June 29, 2024

@jalemy You should be able to create a fork and submit a PR from the fork.

from tailwind-config-viewer.

jalemy avatar jalemy commented on June 29, 2024

@rogden Thank you so much!
Sorry for the delay in submitting a pull request.

from tailwind-config-viewer.

rogden avatar rogden commented on June 29, 2024

No worries @jalemy! Thanks for the PR. It looks good overall. I'll be make a few small changes. Notably moving the default value into a defaultOptions.js file to prevent us needing to duplicate the default string a few times. I need to do something similar for #23 to set a base font size for rem to px conversions.

from tailwind-config-viewer.

jalemy avatar jalemy commented on June 29, 2024

Thank you for your support<3

defaultOptions.js

I see. that's helpful.

from tailwind-config-viewer.

rogden avatar rogden commented on June 29, 2024

Added in v1.5.0

from tailwind-config-viewer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.