Comments (4)
You are connecting each commit to this Issue.
But in reality, the only matter is the code in the Pull Request. So the relation should be like this:
Issue A ㅡ Pull Request B ㅡ Branch C ㅡ Commit 3 (HEAD) ㅡ Commit 2 ㅡ Commit 1
When you mention the issue number in each commit message, you are actually breaking this relation and just connecting each commit to the issue right away. What does that mean? Does it have something to you? What would happen if you don't connect it? Is there any problem?
from dhlottery-api.
늦게 봣네요.. merge 감사합니다.ㅎㅎ!
from dhlottery-api.
@seunggabi not important thing but you'd better remove the pr number in each commit message. As you can see above, your commits are distracting the issue page.
from dhlottery-api.
@seunggabi not important thing but you'd better remove the pr number in each commit message. As you can see above, your commits are distracting the issue page.
hmm.. I don't agree with you.
commit & pr connection is important.
I use this. https://gist.github.com/seunggabi/8fa40a3585d37519db5beab5f0563766
from dhlottery-api.
Related Issues (20)
- 예치금 조회 기능 오류 HOT 5
- 예치금 충전용 가상계좌 설정 기능 오류 HOT 5
- 케이뱅크 계좌 미연동 유저의 고정 가상계좌 입금 기능 구현
- Google Colab, Codespace 에서 실행 시 구매 실패 HOT 3
- 번호 출력 결과가 한 칸씩 밀림 HOT 2
- 이메일 전송 기능이 정상 작동하지 않음
- 수동구매 HOT 1
- user 옵션 관련 문의 HOT 1
- buy_lotto645를 제외한 향후 API 기능 추가 계획 문의 HOT 2
- 계정 정보 입력을 위한 커맨드 라인 기능 추가 요청 HOT 4
- 사용자 계정 정보 세팅 관련 문서내용 개선 HOT 2
- pylint rule 수정: Remove `W0707`
- no stdout (quite) mode HOT 2
- -q 옵션을 -y 옵션으로 명칭 변경 HOT 1
- 로그 정책 설정 및 반영 HOT 2
- 리드미에 뱃지달기
- replace argparse with typer HOT 1
- fix image in readme HOT 2
- add instruction for newly added features to README HOT 1
- README 에 gif 시연 영상 추가
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dhlottery-api.