Code Monkey home page Code Monkey logo

Comments (10)

krlmlr avatar krlmlr commented on June 20, 2024

I like the approach of shgit as a much lighter-weight tool that focuses on the main task: the prompt and providing top-level commands. We don't need a Makefile, we don't need opinionated aliases, and it's great to optimize for syscalls for better Windows support. Having my own aliases available is still important to me, though.

from shgit.

roeme avatar roeme commented on June 20, 2024

Yup, this will be supported, in fact, already is. It seems that I didn't push the corresponding commits here to github. Doing this in a minute.

from shgit.

roeme avatar roeme commented on June 20, 2024

As of 2e51aff, should work now.

from shgit.

krlmlr avatar krlmlr commented on June 20, 2024

Thanks. I'm now seeing:

...
Reading color escapes from git...
bash: ./shgit.sh: line 122: syntax error near unexpected token `git'
bash: ./shgit.sh: line 122: `git diff --ours '

Could my do alias be a problem?

from shgit.

krlmlr avatar krlmlr commented on June 20, 2024

After removing that for loop, aliases work for me, but the color in the prompt is gone. Leaving the issue open for now.

from shgit.

krlmlr avatar krlmlr commented on June 20, 2024

I see now, the shell mistakes the do as an alias. Maybe use \do ? (OTOH, it's probably not too bright to alias a shell keyword...)

from shgit.

roeme avatar roeme commented on June 20, 2024

Yeah, this is a bit of a conundrum: I don't want to constrain the user in what kind of aliases can be used, but at the same time, as you correctly pointed out, this clashes a bit with the shell in general. Maybe there's an elegant way out of this. Thinking.

from shgit.

krlmlr avatar krlmlr commented on June 20, 2024

I think we can avoid setting aliases that are one of ! case coproc do done elif else esac fi for function if in select then until while { } time [[ ]], with a warning. The alias is still available with e.g. git do, but not as a top-level alias.

(Also, a "quiet" where initialization info isn't shown would be great.)

from shgit.

roeme avatar roeme commented on June 20, 2024

That is a good idea, and tentatively implemented with 308c7ed

from shgit.

krlmlr avatar krlmlr commented on June 20, 2024

Thanks for looking into it!

from shgit.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.