Comments (3)
JehandadKhan
commented on July 27, 2024
On Tue, Apr 2, 2024 at 12:54 AM Jun Liu ***@***.***> wrote:
@atamazov <https://github.com/atamazov> could you help? We need to
disable these following tests when XNACK is positive.
we can sort of
const auto target = conv_ctx.GetStream().GetTargetProperties();
if(target.Xnack() && *target.Xnack())
return false;
#2865 <#2865>
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| FAILED TESTCASES |
+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------+
| Test Case | Test Result |
+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------+
| CBAFind2InferSolverTest/ConvBiasActivFind2InferTestFloatFusionFind.ConvBiasActivFind2Float_testFind/(3, (N: 1 C:64 H:56 W:56 k: 64 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAFind2InferSolverTest/ConvBiasActivFind2InferTestFloatFusionFind.ConvBiasActivFind2Float_testFind/(3, (N: 1 C:64 H:56 W:56 k: 64 y:3 x:3 pad_y:1 pad_x:1 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:1024 H:14 W:14 k: 2048 y:1 x:1 pad_y:0 pad_x:0 stride_y:2 stride_x:2 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:1024 H:14 W:14 k: 256 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:1024 H:14 W:14 k: 512 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:128 H:28 W:28 k: 128 y:3 x:3 pad_y:1 pad_x:1 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:128 H:28 W:28 k: 512 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:128 H:56 W:56 k: 128 y:3 x:3 pad_y:1 pad_x:1 stride_y:2 stride_x:2 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:2048 H:7 W:7 k: 512 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:256 H:14 W:14 k: 1024 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:256 H:14 W:14 k: 256 y:3 x:3 pad_y:1 pad_x:1 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:256 H:28 W:28 k: 256 y:3 x:3 pad_y:1 pad_x:1 stride_y:2 stride_x:2 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:256 H:56 W:56 k: 128 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:256 H:56 W:56 k: 512 y:1 x:1 pad_y:0 pad_x:0 stride_y:2 stride_x:2 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:256 H:56 W:56 k: 64 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:3 H:224 W:224 k: 64 y:7 x:7 pad_y:3 pad_x:3 stride_y:2 stride_x:2 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:512 H:14 W:14 k: 512 y:3 x:3 pad_y:1 pad_x:1 stride_y:2 stride_x:2 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:512 H:28 W:28 k: 1024 y:1 x:1 pad_y:0 pad_x:0 stride_y:2 stride_x:2 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:512 H:28 W:28 k: 128 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:512 H:28 W:28 k: 256 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:512 H:7 W:7 k: 2048 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:512 H:7 W:7 k: 512 y:3 x:3 pad_y:1 pad_x:1 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:64 H:56 W:56 k: 256 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:64 H:56 W:56 k: 64 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
| CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:64 H:56 W:56 k: 64 y:3 x:3 pad_y:1 pad_x:1 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) | FAILED |
+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------+
—
Reply to this email directly, view it on GitHub
<#2866>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABK5ZOIP2TL3J2GTQ3NKRJ3Y3JBXXAVCNFSM6AAAAABFSW3ADOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYTSNRRHEZDCNY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
from miopen.
atamazov
commented on July 27, 2024
@JehandadKhan @cderb @junliume
It seems like some (or all) of the Fused solvers become inapplicable for the tested configs when XNACK is enabled on target.
I see two options for CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall tests
- (1) When XNACK is enabled, skip the test.
- (2) When XNACK is enabled, use the narrowed list of configs, i.e. those that remain applicable for XNACK-enabled targets instead of
MIOpen/test/gtest/conv_test_base.hpp
Line 85 in c55cc82
Ditto WRT CBAFind2InferSolverTest/ConvBiasActivFind2InferTestFloatFusionFind.ConvBiasActivFind2Float_testFind except that the list of configs-under-the-test is defined at
MIOpen/test/gtest/conv_test_base.hpp
Line 75 in c55cc82
I would prefer option (2), if possible, but I am not sure if XNACK targets are important for us and if we have any applicable fused solvers. The final decision is up to the respective engineer.
Please let me know if you need more assistance.
from miopen.
JehandadKhan
commented on July 27, 2024
@cderb Please see this thread wrt your PR #2870
from miopen.
Related Issues (20)
- Unable to builld MIOpen from source on SLES HOT 1
- [XNACK] GPU is asleep during the copy and not waking back up when it should. HOT 7
- Build failure Unable to found boost_filesystem HOT 2
- Reproduce kernel cache binary files in MIOpen HOT 1
- [urgent] HipBuildImpl() seems fail to create temp dir or due to no GPU presents in build env HOT 6
- [WA] re-enable conv_hip_implicit_gemm_grouped_bwd_xdlops after kernel dev work
- Softmax invoking FP16 kernel for FP32 input
- [GEMM group conv] Incorrect GPU time when GemmBwd1x1_stride1 and GemmFwd1x1_0_1 are invoked in "Run" mode. HOT 1
- [URGENT] error: no member named 'for_each_n' in namespace 'std' HOT 5
- Excessive warning messages on workspace provided and required (IsEnoughWorkspace) after #2947 HOT 3
- Build process, which to follow? HOT 1
- [Windows] graphapi gtests are not compiling due to missing class methods HOT 2
- Regenerating KDB in the `develop` branch is currently not possible. HOT 2
- MIOpen unit test link issue : ld.lld: error: undefined symbol: dladdr and undefined reference due to --no-allow-shlib-undefined HOT 5
- naive_conv_nonpacked_fwd_nchw_half_double_half in KDB cache breaks after #2863 HOT 5
- Tip of `develop` branch fail to build on older Linux distributions HOT 8
- Remove `setEnvironmentVariable` from the tests and use `env::update(VAR, value)` instead. HOT 3
- Enable hipBLASLt as an optional backend for MIOpen GEMM kernels HOT 2
- Bring back std::unordered_map to old systems HOT 2
- [SLES][RHEL8] error: no member named 'exclusive_scan' in namespace 'std HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from miopen.