Code Monkey home page Code Monkey logo

Comments (7)

Duck-m-a-n avatar Duck-m-a-n commented on June 19, 2024 1

Your fix did the job I can't thank you enough! Just had to include url=

from sportsipy.

davidjkrause avatar davidjkrause commented on June 19, 2024 1

My patch for pyquery2 breaks many existing tests. Note that many of the current tests already don't pass, but the pyquery change breaks more.

I'm working on fixing all the test cases, and will update my branch. Some need fixing for the pyquery change, others are broken in base, and others don't fail but will if the locally stored HTML is updated because the source site has change format.

This is all a pretty big effort, but I'm making solid progress on this and plan to get my fork of this repo at least mostly working in the next few days. I've made many changes to fix issues, but the best approach would be to break the work into separate related patches, rather than just a bulk update.

from sportsipy.

ianstack avatar ianstack commented on June 19, 2024

I have the same issues :(

from sportsipy.

macgormain avatar macgormain commented on June 19, 2024

Same issue here. I went to the sportsreference site and it seems to have created other websites that hold the actual information. This project may have just been torpedo'd because of it.

from sportsipy.

davidjkrause avatar davidjkrause commented on June 19, 2024

Ran into this error and found after some investigating I had updated my packages to include pyquery=2.0.0, instead of 1.4.0. This new version of pyquery requires explicit identifcation of URLs. (Note: In my personal project I needed the later pyquery for other code I was also running along with sportsipy.)

This commit worked for me to get schedules for various leagues, and I updated the rest of the code where it appeared URL identification was needed as well.

I could probably turn this into a pull request, but I'm not sure this project is being actively updated now.

bcd92b5

The specific branch this commit is on is:

https://github.com/davidjkrause/sportsipy/tree/pyquery2

Interested to hear if this helps anyone get by the issues mentioned above.

from sportsipy.

swisi avatar swisi commented on June 19, 2024

Will the solution of @davidjkrause be implemented?

from sportsipy.

davidjkrause avatar davidjkrause commented on June 19, 2024

https://github.com/davidjkrause/sportsipy/tree/pyquery2 is updated with all tests fixed, and a number of other fixes for recent data format changes.

Planning to continue working on my branch / fork to bring in other PRs which fix data issues and have been sitting for a while.

from sportsipy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.