libddcutil segfaults with dlopen about ddcutil HOT 7 CLOSED

Ref: fastfetch-cli/fastfetch#499

If I remove the dlclose it won't crash

from ddcutil.

Thank you for the report. There had been vague assertions in the past about dlopen()/dlclose() not working. Your detailed report makes the locus of the problem obvious.

I have pushed the needed changes to branch 2.0.0-dev. For now trace messages are emitted unconditionally - that of course will change. More significantly, the termination function in the mainline sleeps for 4 seconds to allow for the sleep in the polling loop to complete, after which the polling loop checks if the terminate flag is set. Is this a problem for you? If so, the sleep duration in the polling loop could be decreased, increasing the frequency with with the loop checks for rare display hotplug events.

from ddcutil.

More significantly, the termination function in the mainline sleeps for 4 seconds to allow for the sleep in the polling loop to complete, after which the polling loop checks if the terminate flag is set. Is this a problem for you?

It's a serious problem for me. My program is performance sensitive and I don't want any delays. I'd rather not dlclose it and leak the memories.

I don't need watch. My program should end in seconds. Can we have a flag / option to disable the watch thread?

from ddcutil.

Yes. Function ddca_init(), new in release 2.0.0, could be made to control whether watching for display hotplug events occurs, either through a flag on argument opts, or using the option string argument libopts. I need to think through which is better and what the defaults should be.

from ddcutil.

Function ddca_init() now recognizes strings "--enable-watch-displays" and "--disable-watch-displays" in its libopts string argument. Haven't decided yet what the default should be, but in any event if you specify "--disable-watch-displays" explicitly that will override the default. I have pushed the changes to branch 2.0.0-dev.

from ddcutil.

Why did you choose to use dlopen()/dlclose() instead of just linking to the shared library? Is it so that your program will execute even if the required version of libddcutil is not present, or is there some other reason?

from ddcutil.

Is it so that your program will execute even if the required version of libddcutil is not present?

even if libddcutil is not present

from ddcutil.