[BUG] Unable to fetch any channel information after refresh. about embeddedchat HOT 3 CLOSED

@abhinavkrin, I believe the issue lies in the execution order of the getChannelInfo or getCurrentUser function with respect to whether the currentUser or currentUser.authToken has been set. Upon refreshing, before currentUser is set, it sends a request to the backend to obtain the userId and authToken using const { userId, authToken } = await this.auth.getCurrentUser() || {};. The function runs before the currentUser or currentUser.authToken is set, causing both variables to return undefined. Consequently, it sends a request to the Rocket Chat REST API with undefined information, leading to the inability to fetch the required data upon refresh. I would like to address this issue, but I am unsure how to fix the order of execution. Could you please guide me on this so that I can begin working on it?

I have debugged the issue, and here are my findings:

Console logs on refresh:

In RocketChatAuth.ts, I used the getCurrentUser() function to debug the issue:

from embeddedchat.

After debugging, I found that in the EmbeddedChat.js frontend file, the isUserAuthenticated variable was being set to true before successfully connecting to the RCInstance. This premature setting caused a state change, triggering the execution of the useEffect hook which runs getChannelInfo() function in ChatHeader.js. Since this function requires user information to fetch data which is not available as of now, it sent undefined credentials to the REST API backend, resulting in an error response and the inability to retrieve channel information.

To fix this, I modified the code so that isUserAuthenticated changes to true only after a successful connection is established. This ensures that this.currentUser is properly set on the backend, allowing for correct functionality upon refresh. I've submitted a pull request for your review, checking if my changes are correct.

from embeddedchat.

Thanks @Spiral-Memory for the investigation. 💯

from embeddedchat.