Code Monkey home page Code Monkey logo

Comments (2)

Spiral-Memory avatar Spiral-Memory commented on June 17, 2024

Hey @abhinavkrin , I would like to work on this issue as discussed, I feel that the problem arises because the API used to fetch channel information is /api/v1/channels.info, which can't retrieve the information of private channels. To fetch information of private channels, the API /api/v1/rooms.get or /api/v1/groups.info has to be used. Also, we can use the /api/v1/groups.${query} endpoint to fetch messages and get roles for private channels(groups).The suggested approach is to use both APIs in combination to handle both kinds of channels. Let me know about the approach that you think could be taken to fix this.

from embeddedchat.

Spiral-Memory avatar Spiral-Memory commented on June 17, 2024

I have submitted the PR following the approach I proposed. Please let me know if any changes are necessary.

Note: This PR may lead to merge conflicts with #419 and #421 due to alterations in similar locations. Additionally, PR #427 is essential to maintain synchronization on refresh. These four PRs are closely connected and collectively address the comprehensive issue #417 you advised me to break down into separate tasks. As you begin the review, I will resolve any merge conflicts with each merge. Thank you!

from embeddedchat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.