Code Monkey home page Code Monkey logo

Comments (8)

doudou avatar doudou commented on August 17, 2024

can you be more specific ? What you did, what happens, what you expected.

from autoproj.

D-Alex avatar D-Alex commented on August 17, 2024

By calling "amake XYZ" I expect autoproj to pull in all dependent packages listed in XYZ/manifest.xml and builds them before triggering the build for XYZ. This does not happen if XYZ is directly listed in the autoproj/manifest.xml (section layout). Also if an unknown packages is listed in the XYZ/manifest.xml autoproj does yell in this particular case.

from autoproj.

doudou avatar doudou commented on August 17, 2024

Got it.

This is a bad and unexpected consequence of another feature ... That you can force building an excluded package by adding it explicitly in the layout. Since missing dependencies are handled by the exclusion mechanism, it also covers those.

Will have to add a special marking in the manifest to force the build of the package.

I see two options:

  • introduce a new section (e.g. force_build)
  • add a ! marking on packages in the layout (e.g. - !tutorials/message_driver)

Thoughts ?

from autoproj.

doudou avatar doudou commented on August 17, 2024

I can't reproduce the problem with autoproj not checking out dependencies. Note that not installing osdeps is expected behaviour (albeit an annoying one) as osdeps are pretty costly to check.

from autoproj.

D-Alex avatar D-Alex commented on August 17, 2024

To reproduce the problem just add an unknown dependency to a package directly listed in the manifest

layout
 - image_processing/frame_helper

in the frame_helper/manifest.xml

 <depend package="image_processing/unknown" />

amake image_processing/frame_helper is not yelling and builds the package. This is not the case if the package is removed from the layout.

from autoproj.

doudou avatar doudou commented on August 17, 2024

I could reproduce that. But you also mention that dependencies are not built and/or checked out before the packages that depend on them. That's what I could not reproduce.

from autoproj.

D-Alex avatar D-Alex commented on August 17, 2024

I cannot reproduce it either but I will keep an eye on this.

Concerning the force_build, how about adding a flag to autoproj (amake) signalizing that dependencies are ignored. Also, I would print an information for the user after a package build failed that he can force the build with amake --force-build.

from autoproj.

doudou avatar doudou commented on August 17, 2024

Concerning the force_build, how about adding a flag to autoproj (amake) signalizing that dependencies are ignored.

Yes, autoproj should want the user that the package should not be built but will be anyways. However, this goes with the force_build or ! marker, not in replacement of (or ?)

Also, I would print an information for the user after a package build failed that he can force the build with amake --force-build.

If the builds fails, he/she should not have to use --force

from autoproj.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.