Several Collections library keywords do not work with non-string items about robotframework HOT 4 CLOSED

Originally submitted to Google Code by @pekkaklarck on 6 Jul 2008

This is clearly a bug and it occurs also in 2.0 version. A simple fix is replacing
the highlighted print statement e.g. with

print 'Appending value %s' % str(value)

I took a quick look at the source code of Collections library and noticed that most
keywords there do not log what they are doing. Instead of just fixing the reported
issue it's better to go through all the keywords and add unified logging. It might be
that the default level is better to be DEBUG since list/dictionary operations may
involve a lot of entries. Anyway, logging should be handled by internal helper method
so that the default level is easy to change.

Additionally noticed that some of the keyword docs in Collections library have lines
longer than 78 chars. This ought to be fixed as well.

These issues will be fixed in next released version regardless is it 2.1 or 2.0.1.

from robotframework.

Originally submitted to Google Code by @pekkaklarck on 21 Jul 2008

To be implemented in 2.0.1 version.

from robotframework.

Originally submitted to Google Code by @pekkaklarck on 23 Jul 2008

I fixed logging (i.e. the print statement) simply by removing it. At the same time I
also did a little cleanup, mainly for documentation. Committed in r385.

I'm not sure should keywords in Collections library log what they are doing or not.
Adding logging is anyway out of the scope of 2.0.1, and I added a new issue 50 for it.

from robotframework.

Originally submitted to Google Code by @pekkaklarck on 24 Aug 2008

I noticed that there were several other keywords in Collections library that did not
work with non-string items. Affected keywords were:

Dictionaries Should Be Equal
Dictionary Should Contain Sub Dictionary
List Should Contain Sub List

These keywords failed because they had code like:

diffs = [value for value in L2 if not L1.count(value) > 0 ]
error = ', '.join(diffs)

This fails when 'diffs' contains non-strings because 'join' expects a list of strings
as arguments. Acceptance tests only used lists with strings and dictionaries with
strings as keys and thus they didn't found the problem.

These keywords were fixed in r503 and tests/docs committed in r504. Fixes are
included to 2.0.1.

from robotframework.