feature: easily register and bundle translation data with a lazy loaded module about angular-l10n HOT 3 CLOSED

Hi @pweyrich,

got it, but the loading of translation data depends on L10nTranslationLoader, and your custom implementation of it.

It's true, the default loader (https://github.com/robisim74/angular-l10n/blob/master/projects/angular-l10n/src/lib/services/l10n-translation-loader.ts#L22-L28) use translation data as typescript files, but it is intended for basic scenarios, such as simple applications or tests.

The request for a lazy module is done via an http request, and I think that the translation files in that case should also make an http request, to keep the bundle lighter.

I leave this request open to other opinions.

from angular-l10n.

I looked at the possible alternatives: I intend to keep the services and tokens of this library singleton, and the forChild method should be used to inject the services, without implementing any other logic.

On the other hand, here it is sufficient to load the new assets in the lazy module:

export class LazyModule {
    constructor(private translation: L10nTranslationService) {
        this.translation.loadTranslation([{ name: 'lazy', asset: lazyTranslationData}]);
    }
}

from angular-l10n.

Closed due to inactivity

from angular-l10n.