Code Monkey home page Code Monkey logo

Comments (6)

uzadude avatar uzadude commented on May 26, 2024 1

Hi,
yup, it's related to what you wrote in the last sentence.
Our use-case is documentation site based on docusaurus (react) which indeed has many pages. The experience we want to give to our customers is basically that they will not even be aware that it is an encrypted site. they will just click the link once, and from there on they will be able to freely navigate between the pages and even share links (without the hashed-password)
with one another.

from staticrypt.

robinmoisson avatar robinmoisson commented on May 26, 2024

Hey @uzadude, thanks for reporting and for opening a PR! I'm curious, could you share a little more about why that's necessary in your setup?

I'd think you can either send the link with the auto-decrypt hash, and people can bookmark it or set it as a link on a text in a doc (like this), or you can send the person both the regular link and the password - the password should be unique anyway, and sending the link with the auto-decrypt hash is the same security wise.

In general I want to be conservative in adding new toggles to staticrypt to keep it easy to understand and to use for newcomers, so I want to make sure the current abilities don't cover the use case in a significant way.

That being said as I'm writing this I'm realizing, maybe it'd be useful to share an auto-decrypt link to a project that has multiple pages, where we'd want a single entry link to auto-decrypt all pages. 🤔

from staticrypt.

robinmoisson avatar robinmoisson commented on May 26, 2024

I think that makes sense, though maybe unusual for share links, since encrypting multiple pages is a common use case.

Thanks for the suggestion!

from staticrypt.

samibkf avatar samibkf commented on May 26, 2024

Hello @robinmoisson & @uzadude , I really need the shareable link auto-remember feature.
If it's already implemented, I'd be grateful if you could point me towards how to use it!

from staticrypt.

uzadude avatar uzadude commented on May 26, 2024

@samibkf - we ended up using a patch (with patch-package) with the contents of #184 and it works great.

from staticrypt.

robinmoisson avatar robinmoisson commented on May 26, 2024

Woops sorry, looks like time flew faster than I noticed. This is now a feature of version 3.4.0 that has just been pushed to npm - you can add &remember_me to your sharable link, or add the --share-remember flag to your command to get the link, as is now documented in the readme.

@uzadude the hashed password is preferred in the url fragment rather than query params (#staticrypt_pwd=... rather than ?staticrypt_pwd=...) to avoid sending it to the server since it's only needed client-side. We still support query param for backward compat reason, so I added support for the remember_me to be passed in query param too like you did, so it should be backward compatible with your patched version as well. 🙂

const rememberMeQuery = queryParams.get(rememberMeKey);

Let me know if you guys hit any problem using it, and thanks for the idea! (and final push 🙏 )

from staticrypt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.