Code Monkey home page Code Monkey logo

Comments (8)

robfig avatar robfig commented on June 8, 2024

I think that the reason I used 'effective' instead of 'now' is to avoid missing jobs in case of random pauses. I agree that your use case seems pretty motivating to adjust things. All of the tests pass when I make the change you describe, so at least I doesn't break anything in the typical case.

Want to give it a shot and report back how it goes?

from cron.

ahall avatar ahall commented on June 8, 2024

Yeah will do. I have tested messing around with the clock and everything works fine with the change. Normal behaviour seems ok so I think it will be fine. I will report back in few weeks and let you know how it goes.

from cron.

ahall avatar ahall commented on June 8, 2024

Hi @robfig, thought I'd report back.

I've been using my patch now in production for few days and this has solved my problems and doesn't seem to have had any regression effects. Should we push this fix to master?

from cron.

robfig avatar robfig commented on June 8, 2024

Good to hear! My only concern is the behavior during daylight savings transitions. I'm not sure how to test that though..

from cron.

dvdplm avatar dvdplm commented on June 8, 2024

Is this fix currently under consideration for v2?

from cron.

robfig avatar robfig commented on June 8, 2024

Sure, I'm happy to merge it

from cron.

dvdplm avatar dvdplm commented on June 8, 2024

Lovely! :)

from cron.

robfig avatar robfig commented on June 8, 2024

I believe this was merged and all good. Closing

from cron.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.