Comments (8)
I think that the reason I used 'effective' instead of 'now' is to avoid missing jobs in case of random pauses. I agree that your use case seems pretty motivating to adjust things. All of the tests pass when I make the change you describe, so at least I doesn't break anything in the typical case.
Want to give it a shot and report back how it goes?
from cron.
Yeah will do. I have tested messing around with the clock and everything works fine with the change. Normal behaviour seems ok so I think it will be fine. I will report back in few weeks and let you know how it goes.
from cron.
Hi @robfig, thought I'd report back.
I've been using my patch now in production for few days and this has solved my problems and doesn't seem to have had any regression effects. Should we push this fix to master?
from cron.
Good to hear! My only concern is the behavior during daylight savings transitions. I'm not sure how to test that though..
from cron.
Is this fix currently under consideration for v2?
from cron.
Sure, I'm happy to merge it
from cron.
Lovely! :)
from cron.
I believe this was merged and all good. Closing
from cron.
Related Issues (20)
- I have deployed crons with @daily in cloud foundry and it is not working HOT 1
- What is the status of the repo? HOT 4
- When creating a new cron object, multiple construction methods are provided.
- provide ant way to change the value of Now for testing purposes HOT 1
- I cannot pass second as 6th param for cronjob HOT 2
- Troubles in docker
- crontab run error HOT 2
- [discuss] Discussion of executing a single server under multiple nodes HOT 3
- does this package support standard crontab expr HOT 1
- Why is time zone not supported? this is exactly what i need HOT 1
- cron.New().Remove() HOT 1
- performance wise question
- During the execution process of scheduled tasks, a change in the system time can result in incorrect execution timing. HOT 2
- Tag 3.0.1 too old HOT 1
- How to start job from the past time?
- How to retrieve command
- Wrong Result on Sync Cron HOT 1
- Removing entry does not update the cron HOT 1
- cron expression failed to be parsed - unknown unit "d"
- How to schedule job to run on every 2nd thursday of month at 10:10 AM HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cron.