ToValue converting array into map[string]interface{} about otto HOT 7 CLOSED

FYI, the current Otto revision I'm testing is 04ea4a2. The one we've been using that works fine is adf21d0 from 5/15 ("No rush to change the interface of Value.Export()"). I'm running Go 1.1 on Mac OS X 10.8.4.

from otto.

If I call value.Type() at the start of ottoValueToStringArray(), the result is "GoArray". So it looks like the problem is in converting a JS GoArray back into a native Go array.

from otto.

Sorry about that. The problem is (probably) around here:

https://github.com/robertkrimen/otto/blob/master/value.go#L625

This is the commit that "broke" it:

6669f98

We have different types for a Go slice versus a Go array, now.

I'm not sure exactly why the export tests did not catch this, though...

from otto.

Maybe line 628 should read

if object.class == "Array” || object.class == “GoArray” {

?

from otto.

Yeah, that fixed it.

from otto.

The bug isn't fixed. My test is still failing — it's that assertion that I commented out when pasting it above. The result of Export is now correctly a string array, but unfortunately its value is nil :(

    channelmapper_test.go:33
    assert.DeepEquals(t, strings, []string{"foo", "bar", "baz"})    

    expected: []string{"foo", "bar", "baz"}
         got: []string(nil)
--- FAIL: TestOttoValueToStringArray (0.08 seconds)

The unit test you added (Test_issue24) doesn't catch this because it only verifies the return type, not the actual value.

from otto.

Oops, never mind — my own code was broken (it was still expecting Value to return []interface{}, not []string!)

from otto.