Hello NIH-ers! I've run into a problem case whenever more than one S

Different SysEx messages in the same block all come through as duplicates (VST3) about nih-plug HOT 2 OPEN

robbert-vdh commented on May 27, 2024

Different SysEx messages in the same block all come through as duplicates (VST3)

from nih-plug.

Comments (2)

robbert-vdh commented on May 27, 2024

What host did you try this with? It may be an issue with that host. If you check the code here there's nothing that could cause it to read the same buffer multiple times unless the host used the same pointer for each event:

nih-plug/src/wrapper/vst3/wrapper.rs

Lines 1143 to 1150 in b31bafd

    
           // 0 = kMidiSysEx 
        
           let event = event.event.data; 
        
           // `NoteEvent::from_midi` prints some tracing if parsing fails, which is 
        
           // not necessarily an error 
        
           assert!(!event.bytes.is_null()); 
        
           let sysex_buffer = 
        
               std::slice::from_raw_parts(event.bytes, event.size as usize);

And this works just like you'd expect in REAPER 6.79 with multiple SysEx events sent as part of a single process call.

from nih-plug.

ijijn commented on May 27, 2024

Ah, thank you for pointing out exactly where in the code this is all going on. As it happens, I'm experiencing this specifically with REAPER (x64) on Windows 11. Hmm, may have to do some further digging to get to the bottom of it ⛏️

from nih-plug.

Different SysEx messages in the same block all come through as duplicates (VST3) about nih-plug HOT 2 OPEN

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// 0 = kMidiSysEx
	let event = event.event.data;

	// `NoteEvent::from_midi` prints some tracing if parsing fails, which is
	// not necessarily an error
	assert!(!event.bytes.is_null());
	let sysex_buffer =
	std::slice::from_raw_parts(event.bytes, event.size as usize);